623666 - Empty tag results in a traceback

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Add >> as a tag in the edit page and save changes
2. Notice that an empty tag is created
3. Navigate to the dashboard

observed behavior:
traceback details

File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 109, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 77, in wrapper
   return f(*args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 69, in wrapper
   return f(*args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 24, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 101, in dashboard
   return jingo.render(request, 'devhub/addons/dashboard.html', data)

 File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 78, in render
   rendered = render_to_string(request, template, context)

 File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 96, in render_to_string
   return template.render(**get_context())

 File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/templates/devhub/addons/dashboard.html", line 1, in top-level template code
   {% extends "devhub/base.html" %}

 File "/data/amo_python/www/preview/zamboni/apps/devhub/templates/devhub/base.html", line 4, in top-level template code
   {% set editable = "no-edit" if not has_perm(request, addon, dev=True) %}

 File "/data/amo_python/www/preview/zamboni/templates/base.html", line 94, in top-level template code
   {% block main_content %}

 File "/data/amo_python/www/preview/zamboni/templates/base.html", line 99, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/amo_python/www/preview/zamboni/apps/devhub/templates/devhub/addons/dashboard.html", line 71, in block "content"
   {{ item }}

 File "/data/amo_python/www/preview/zamboni/apps/devhub/models.py", line 234, in __unicode__
   return self.to_string()

 File "/data/amo_python/www/preview/zamboni/apps/devhub/models.py", line 224, in to_string
   arg.get_url_path(), arg.tag_text)

 File "/data/amo_python/www/preview/zamboni/apps/tags/models.py", line 34, in get_url_path
   return reverse('tags.detail', args=[self.tag_text])

 File "/data/amo_python/www/preview/zamboni/apps/amo/urlresolvers.py", line 58, in reverse
   url = django_reverse(viewname, urlconf, args, kwargs, prefix, current_app)

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/urlresolvers.py", line 390, in reverse
   *args, **kwargs)))

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/urlresolvers.py", line 336, in reverse
   "arguments '%s' not found." % (lookup_view_s, args, kwargs))

NoReverseMatch: Reverse for 'tags.detail' with arguments '(u'',)' and keyword arguments '{}' not found.

Comment 1

[Andy McKay]

No more empty tags allowed any more.

https://github.com/jbalogh/zamboni/commit/98f636744f0dc369cdc42692705fa86b5b4fb795

Comment 2

[krupa raj[:krupa]]

verified