623675 - Increase pageFitGranularity back to 9 (don't snap zoom to 100% as aggressively)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

In bug 604149 we changed the "pageFitGranularity" threshold to 5, so that pages up to 1/5 (20%) wider than the screen width would be unscaled, instead of zoomed out to fit the page width.  This was done so that pages with our default 980px viewport would still appear unscaled by default on 800px-wide devices.

With bug 604765, our default viewport is again 800px so this is not needed in most cases.  Having a high value for this pref leads to some unpredictable zooming behavior.  This reverts it back to the previous value of 9.

Now that our scaled rendering is improving, we could also consider removing this pref altogether, and always zooming out to fit the page width.

Comment 1

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/80597ac7646a

Comment 2

[Aaron Train [:aaronmt]]

Test/Samples pages for verification?

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to comment #2)
> Test/Samples pages for verification?

We should verify that bugs like bug 588504 do not regress.  (Can't find the bug, but there was a similar problem with the login form on the non-mobile www.facebook.com; we should verify it does not regress either.)

The checkin contains some automated test cases, but they are generated by an SJS script so we can't easily link to them on the web.  We could generate some similar files for manual tests if needed.

Comment 4

[Matt Brubeck (:mbrubeck)]

Please ignore my comment 3; I had this confused with a different bug...