Screenshot-related options are missing/ do not match mocks

RESOLVED FIXED in 5.12.6

Status

RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: krupa.mozbugs, Assigned: gkoberger)

Tracking

Details

(Whiteboard: [Edit page], URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
As per http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/03_edit_listing_expanded.png, users can do the following with their screenshots

* Details
* Move up
* Move down
* Delete

Right now, we allow users to delete the screenshots. But the delete link does not looks similar to the mock up
Sorry I didn't realize there was a v3 mockup, I used the v1 mockup.
(Reporter)

Comment 2

8 years ago
Created attachment 501798 [details]
screenshot
Summary: Screenshot related options are missing/ do not match mocks → Screenshot-related options are missing/ do not match mocks

Updated

8 years ago
Assignee: nobody → amckay
(Assignee)

Updated

8 years ago
Assignee: amckay → gkoberger
now now, there's enough bugs for everyone to get one.
(Assignee)

Comment 4

8 years ago
If I'm not mistaken (chowse?), the screenshot Krupa posted is outdated, too.

http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction/screenshot_video.png
Screenshot ordering is bug 622610, but we can change the delete text.  If we have the size/dimensions/type data right there, we can add it, but it's not important.  Size is most useful.  We automatically convert everything to PNG when they upload, so that's kind of a throw away.
(In reply to comment #4)
> If I'm not mistaken (chowse?), the screenshot Krupa posted is outdated, too.
> 
> http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction/screenshot_video.png

You're correct. The UI in the interactions wireframe (w/ bottom-aligned metadata and the (x) remove icon) is the intended design. However, the 'Add Screenshot' button is fine, unless we add video support at a later date.
(Assignee)

Comment 7

8 years ago
clouserw: I didn't do size/dimensions/type intentionally, since almost every single one of them will be "700x525" and "png" (and nobody will care about the size, since we're resizing them so there's nothing they can do about it).  As for reordering, you can assign it to me.
(Assignee)

Comment 8

8 years ago
https://github.com/jbalogh/zamboni/commit/cf206293df0090059590d67d7f384d3b5e1f7c1d
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.