623786 - [traceback] NoReverseMatch: Reverse for 'tags.detail' with arguments '(u'http://www.cogentco.com/us/',)' and keyword arguments '{}' not found.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://addons.allizom.org/z/en-US/developers/feed?page=28 triggers the following traceback, for me:

Traceback (most recent call last):

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 109, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 77, in wrapper
    return f(*args, **kw)

  File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 69, in wrapper
    return f(*args, **kw)

  File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 238, in feed
    return jingo.render(request, 'devhub/addons/activity.html', data)

  File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 78, in render
    rendered = render_to_string(request, template, context)

  File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 96, in render_to_string
    return template.render(**get_context())

  File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/amo_python/www/preview/zamboni/apps/devhub/templates/devhub/addons/activity.html", line 1, in top-level template code
    {% extends "devhub/base.html" %}

  File "/data/amo_python/www/preview/zamboni/apps/devhub/templates/devhub/base.html", line 4, in top-level template code
    {% set editable = "no-edit" if not has_perm(request, addon, dev=True) %}

  File "/data/amo_python/www/preview/zamboni/templates/base.html", line 94, in top-level template code
    {% block main_content %}

  File "/data/amo_python/www/preview/zamboni/templates/base.html", line 99, in block "main_content"
    {% block content %}{% endblock %}

  File "/data/amo_python/www/preview/zamboni/apps/devhub/templates/devhub/addons/activity.html", line 30, in block "content"
    <p>{{ item }}</p>

  File "/data/amo_python/www/preview/zamboni/apps/devhub/models.py", line 234, in __unicode__
    return self.to_string()

  File "/data/amo_python/www/preview/zamboni/apps/devhub/models.py", line 224, in to_string
    arg.get_url_path(), arg.tag_text)

  File "/data/amo_python/www/preview/zamboni/apps/tags/models.py", line 34, in get_url_path
    return reverse('tags.detail', args=[self.tag_text])

  File "/data/amo_python/www/preview/zamboni/apps/amo/urlresolvers.py", line 58, in reverse
    url = django_reverse(viewname, urlconf, args, kwargs, prefix, current_app)

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/urlresolvers.py", line 390, in reverse
    *args, **kwargs)))

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/urlresolvers.py", line 336, in reverse
    "arguments '%s' not found." % (lookup_view_s, args, kwargs))

NoReverseMatch: Reverse for 'tags.detail' with arguments '(u'http://www.cogentco.com/us/',)' and keyword arguments '{}' not found.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry; crashing link is actually https://addons.allizom.org/z/en-US/developers/feed?page=27 (?page=28 was the referrer).

Comment 2

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/9a8b3ba7b15e23855336e51b761f111128a1829f

If the URL can't resolve, because its an old naughty tag, we don't put the link in and cause the error to bubble. When the old tags get all cleaned (there's a ticket in 4.x for that) this won't be needed.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks, Andy!