Closed Bug 623825 Opened 9 years ago Closed 9 years ago

Remove "Options" button for persona themes

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: tchung, Assigned: fabrice)

References

()

Details

Attachments

(2 files, 1 obsolete file)

Attached image theme options button
The fennec addons manager has an options button present for personas themes.   This doesnt seem necessary since persona themes dont have options.  Most themes i've installed have the button grayed out anyway, but there are occasional themes that has the button enabled... which clicking it does nothing anyway.

I suggesting removing options for persona themes altogether.  In desktop firefox, thats not even there anyway.

See screenshot

Repro:
1) install android nightly: Mozilla/5.0 (Android; Linux armv71; rv:2.0b9pre) Gecko/20110106 Firefox/4.0b9pre Fennec/4.0b4pre	
2) install mobile personas extension from AMO
3) wear a few personas.  Wear "Japanese Flowers" for example
4) Open prefs > Addons manager
5) Verify personas themes have an options button that does nothing.  

Expectd:
- there are no options for personas, so should just remove them for these theme types

Actual:
- option button visible, does nothing when clicked.
Fabrice, If it makes things easier, let's add an attribute to the XBL, hideoptions="true", that would forcibly hide the Options button. Then the add-on could use it for themes.

Or maybe you have a different idea that doesn't require any Fennec code changes. I just wanted to say that we could add support for it to Fennec - not a problem.
Assignee: nobody → fabrice
Attached patch patch (obsolete) — Splinter Review
Attachment #502047 - Flags: review?(mark.finkle)
Comment on attachment 502047 [details] [diff] [review]
patch

No {} needed on the if stmt
Attachment #502047 - Flags: review?(mark.finkle) → review+
Attached patch updated patchSplinter Review
addressing comment
Attachment #502047 - Attachment is obsolete: true
Attachment #502049 - Flags: review?(mark.finkle)
Attachment #502049 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/5e1e0d4fb38b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fix on Mozilla/5.0 (Android; Linux armv71; rv:2.0b9pre) Gecko/20110110 Firefox/4.0b9pre Fennec/4.0b4pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.