623840 - puppet runners should calculate master dynamically based on IP or hostname

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

All of our puppet instances run from hand-rolled scripts.  Rather than edit these scripts with puppet, we should just write the scripts to examine their own IP and/or hostname and determine the appropriate master from that information.  Then we'll never have slaves connecting across datacenters, and all puppet masters can safely contain definitions for all slaves, keeping the fileserver.conf files limited only to local subnets as a backup check to prevent large cross-dc file transfers.

I'm much less worried about accidentally triggering cross-dc file transfers now that I know we've been doing them constantly via NFS (bug 597912), but we should still make a good effort.

Zandr suggested that we use hostname, and that may be the easiest to portably look up in a shell script.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

The manifests now use sort_servers_by_group to accomplish this.