623844 - The treeclosure hook looks for a 'treestatus' css class on tinderbox while the treeclosure_comm_central hook looks for 'tree-status'

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[LegNeato]

The treeclosure hook looks for a 'treestatus' css class on tinderbox while the treeclosure_comm_central hook looks for 'tree-status'. Looking at the tinderbox pages, they are different there (which should be spun off into another bug). In any case, the attached patch looks for both in both hooks.

This took me about an hour to figure out why my new tests were failing, sigh.

Comment 1

[LegNeato]

Attachment: Generalize the regex a bit

Comment 2

[(not currently active) Ted Mielczarek]

Weird, I have no idea why they're different.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 501935 [details] [diff] [review]
Generalize the regex a bit

I don't think you need the [] there, "-?" should match zero or one dashes just fine.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #2)
> Weird, I have no idea why they're different.

I suspect someone in Firefox land decided to redo it at some stage and we've not propagated the changes. Alternately we just got it wrong to begin with.

Comment 5

[Mark Banner (:standard8)]

I'm hoping Christian doesn't mind, but I wanted to move bug 624874 forward, so I've pushed this to the hghooks repo after addressing Ted's comments:

http://hg.mozilla.org/hgcustom/hghooks/rev/905412e3754f

It seems from attachment 502952 [details] [diff] [review] that Christian was intending on addressing those anyway.