Cmd + L is not focusing location bar in popup windows

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Keyboard Navigation
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: rik, Assigned: Terry Long)

Tracking

({testcase})

Trunk
Firefox 10
testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Steps to reproduce:
1) Open any popup window
2) Hit Cmd + L

Expected results:
Location bar is focused

Actual results:
Nothing

Comment 1

6 years ago
javascript:window.open("data:text/html,1", null, "toolbar=no"); void 0

Not being able to Cmd+L, Cmd+C broke my brain.
Keywords: testcase

Updated

6 years ago
Whiteboard: [good first bug]
(Assignee)

Comment 2

6 years ago
Created attachment 570169 [details] [diff] [review]
bug fix with modified test case

I have attached a patch to fix the described bug.
Fixing the bug caused a regression in a functional test, but assuming this bug is correct, then that functional test case is inaccurate. Thus, I also made a change to the test (included in the patch).
Attachment #570169 - Flags: review?(dao)
Comment on attachment 570169 [details] [diff] [review]
bug fix with modified test case

Thanks!
Attachment #570169 - Flags: review?(dao) → review+

Updated

6 years ago
Assignee: nobody → trl
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All

Comment 4

6 years ago
Thanks for the patch!

In my queue, which is going via try then onto inbound:
https://tbpl.mozilla.org/?tree=Try&rev=d3d2522ed095

I fixed the author/commit message locally this time, so nothing further needs to be done here - but for future patches please can you take a look at http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Thanks :-)
Status: NEW → ASSIGNED
Flags: in-testsuite+
Keywords: checkin-needed

Comment 5

6 years ago
Terry, your patch has now landed on mozilla-inbound, which gets merged roughly daily to mozilla-central. Once that merge happens, the mozilla-central changeset link will be posted here and the fix will be visible in the next day's nightly :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f789c2b7c7
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/b7f789c2b7c7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 7

6 years ago
Terry, congratulations on your first patch in the tree! Hope to see you on IRC in #developers soon (see https://wiki.mozilla.org/IRC#Getting_Started for details). 

If you'd like to fix another bug (it would be awesome if you did!) but need some inspiration, pop on & say hi - and we'll find something for you :-)
You need to log in before you can comment on or make changes to this bug.