Closed Bug 623872 Opened 12 years ago Closed 11 years ago

Cmd + L is not focusing location bar in popup windows


(Firefox :: Keyboard Navigation, defect)

Not set



Firefox 10


(Reporter: rik, Assigned: trl)


(Keywords: testcase, Whiteboard: [good first bug])


(1 file)

Steps to reproduce:
1) Open any popup window
2) Hit Cmd + L

Expected results:
Location bar is focused

Actual results:
Nothing"data:text/html,1", null, "toolbar=no"); void 0

Not being able to Cmd+L, Cmd+C broke my brain.
Keywords: testcase
Whiteboard: [good first bug]
I have attached a patch to fix the described bug.
Fixing the bug caused a regression in a functional test, but assuming this bug is correct, then that functional test case is inaccurate. Thus, I also made a change to the test (included in the patch).
Attachment #570169 - Flags: review?(dao)
Comment on attachment 570169 [details] [diff] [review]
bug fix with modified test case

Attachment #570169 - Flags: review?(dao) → review+
Assignee: nobody → trl
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Thanks for the patch!

In my queue, which is going via try then onto inbound:

I fixed the author/commit message locally this time, so nothing further needs to be done here - but for future patches please can you take a look at

Thanks :-)
Flags: in-testsuite+
Keywords: checkin-needed
Terry, your patch has now landed on mozilla-inbound, which gets merged roughly daily to mozilla-central. Once that merge happens, the mozilla-central changeset link will be posted here and the fix will be visible in the next day's nightly :-)
Target Milestone: --- → Firefox 10
Closed: 11 years ago
Resolution: --- → FIXED
Terry, congratulations on your first patch in the tree! Hope to see you on IRC in #developers soon (see for details). 

If you'd like to fix another bug (it would be awesome if you did!) but need some inspiration, pop on & say hi - and we'll find something for you :-)
You need to log in before you can comment on or make changes to this bug.