623872 - Cmd + L is not focusing location bar in popup windows

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Anthony Ricaud (:rik)]

Steps to reproduce:
1) Open any popup window
2) Hit Cmd + L

Expected results:
Location bar is focused

Actual results:
Nothing

Comment 1

[Jesse Ruderman]

javascript:window.open("data:text/html,1", null, "toolbar=no"); void 0

Not being able to Cmd+L, Cmd+C broke my brain.

Comment 2

[Terry Long]

Attachment: bug fix with modified test case

I have attached a patch to fix the described bug.
Fixing the bug caused a regression in a functional test, but assuming this bug is correct, then that functional test case is inaccurate. Thus, I also made a change to the test (included in the patch).

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 570169 [details] [diff] [review]
bug fix with modified test case

Thanks!

Comment 4

[Ed Morley [:emorley]]

Thanks for the patch!

In my queue, which is going via try then onto inbound:
https://tbpl.mozilla.org/?tree=Try&rev=d3d2522ed095

I fixed the author/commit message locally this time, so nothing further needs to be done here - but for future patches please can you take a look at http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Thanks :-)

Comment 5

[Ed Morley [:emorley]]

Terry, your patch has now landed on mozilla-inbound, which gets merged roughly daily to mozilla-central. Once that merge happens, the mozilla-central changeset link will be posted here and the fix will be visible in the next day's nightly :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f789c2b7c7

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/b7f789c2b7c7

Comment 7

[Ed Morley [:emorley]]

Terry, congratulations on your first patch in the tree! Hope to see you on IRC in #developers soon (see https://wiki.mozilla.org/IRC#Getting_Started for details). 

If you'd like to fix another bug (it would be awesome if you did!) but need some inspiration, pop on & say hi - and we'll find something for you :-)