623874 - Use Class::XSAccessor via Moo for faster accessors

Status: NEW

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

There is a module called Class::XSAccessor that generates very very fast accessors, faster than pure-perl accessors:

  http://search.cpan.org/dist/Class-XSAccessor/

It is the fastest accessor generator on CPAN:

http://search.cpan.org/~rkitover/Class-Accessor-Grouped-0.10002/lib/Class/Accessor/Grouped.pm#Benchmark

In my last xt/search.t speed tests, the slowest part was actually calling the ->name and ->id methods on Bugzilla::Object objects over and over. I'm not sure if we can use XSAccessor for those (because they reference $self->NAME_FIELD and $self->ID_FIELD) but it could speed up Bugzilla a bit, very possibly, if we could use it for those and other accessors.