Tests fail if run outside PST8PDT

VERIFIED FIXED

Status

()

Core
JavaScript Engine
P3
trivial
VERIFIED FIXED
19 years ago
16 years ago

People

(Reporter: shaver, Assigned: Phil Schwartau)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(new Date(-2208988799999)).getTimezoneOffset() = 300 FAILED! expected: 480

and then all the other Date tests fail:

    (new Date(955252800000)).getDay() = 0 FAILED! expected: 6
    new Date("Mon Feb 28 19:00:00 GMT-0500 (EST) 2000").getHours() = 19 FAILED!
expected: 16

Help! Help! I'm being oppressed!

Comment 1

19 years ago
oh the pain of Date, will it never end?

Updated

19 years ago
Status: NEW → ASSIGNED

Updated

19 years ago
Component: JavaScript → Javascript Engine

Comment 2

19 years ago
moving to the "JavaScript Engine" component.

Updated

18 years ago
Assignee: cbegle → rginda
Status: ASSIGNED → NEW

Updated

18 years ago
Status: NEW → ASSIGNED
QA Contact: cbegle → rginda

Comment 3

18 years ago
Christine has fixed some of these, Not sure which ones are left.

Comment 4

18 years ago
i'll check em in.
Assignee: rginda → cbegle
Status: ASSIGNED → NEW

Updated

18 years ago
Status: NEW → ASSIGNED

Comment 5

18 years ago
I ran all the tests in mozilla/js/tests/ecma/Date/* and they all ran fine 
without any error. So looks like this has been fixed.


Test List: ecma/Date/<br>
Skip List: (none)<br>
149 test(s) selected, 149 test(s) completed, 0 failures reported (0% failed)<br>
Engine command line: /u/mitesh/seamonkey/mozilla/js/src/js <br>
OS type: Linux skaro.mcom.com 2.2.12-20smp #1 SMP Mon Sep 27 10:34:45 EDT 1999 
i686 unknown<br>
Testcase execution time: 6 minutes, 18 seconds.<br>
Tests completed on Wed Aug 16 14:48:43 2000.<br><br>

Comment 6

17 years ago
previous owner's email invaid. reassigning to a breathing human
to verify that this has been fixed.
Assignee: cbegle → rginda
Status: ASSIGNED → NEW

Comment 7

17 years ago
Over to phil, who is actually working on this issue
Assignee: rginda → pschwartau
QA Contact: rginda → pschwartau
(Assignee)

Comment 8

17 years ago
This should be fixed now. I deleted the hard-coded line TZ_DIFF = -8
contained in 30 testcases. 

Example:  http://lxr.mozilla.org/mozilla/source/js/tests/ecma/Date/15.9.4.3.js


This value is now set dynamically via the function getTimeZoneDiff() in:

          http://lxr.mozilla.org/mozilla/source/js/tests/ecma/shell.js



A further 15 testcases contain "expected" result vectors hard-coded for 
Pacific Standard Time. These tests now call a function that adjusts the 
result vectors for the tester's own timezone. 

Example: http://lxr.mozilla.org/mozilla/source/js/tests/ecma/Date/15.9.3.2-1.js
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

17 years ago
Marking Verified. I have run all the date tests in js/tests/ecma/Date
and js/tests/ecma_3/Date in many different timezones. We are only having 
trouble with a couple specific testcases in a couple of timezones 
east of GMT. See bug 63720, for example.


Since the bulk hard-coding problems have been resolved, marking this bug 
Verified. We can deal with specific issues with specific bugs as above -
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.