Closed
Bug 623986
Opened 14 years ago
Closed 8 years ago
Consider readability of disabled buttons with Personas
Categories
(Thunderbird :: Theme, defect)
Thunderbird
Theme
Tracking
(thunderbird45 fixed, thunderbird46 fixed)
RESOLVED
FIXED
Thunderbird 46.0
People
(Reporter: standard8, Assigned: Paenglab)
Details
Attachments
(1 file)
2.55 KB,
patch
|
aleth
:
review+
mkmelin
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Per bug 599005 comment 6: 'Reviewed by Kris from the editors team. Quote: "Disabled buttons tend to be a bit hard to read, but other than that everything seems to work as expected."' Andreas, can you take a look and see if you think we need some improvement there?
Assignee | ||
Comment 1•8 years ago
|
||
Use the LW-theme text color with reduced opacity instead of GrayText (Linux, Windows) or -moz-mac-disabledtoolbartext (OS X).
Updated•8 years ago
|
Attachment #8701997 -
Flags: review?(aleth) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 2•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/17f2d83ce40a4b25ba6b00680323e56868d2f72f Bug 623986 - Make the buttontext redable of disabled toolbarbuttons with LW-themes. r=aleth
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
Comment 3•8 years ago
|
||
uplift?
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8701997 [details] [diff] [review] LW-text.patch [Approval Request Comment] User impact if declined: Harder to read the toolbarbutton text with dark LW-themes Testing completed (on c-c, etc.): on c-c Risk to taking this patch (and alternatives if risky): low, small CSS changes
Attachment #8701997 -
Flags: approval-comm-aurora?
Updated•8 years ago
|
Attachment #8701997 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 5•8 years ago
|
||
Aurora: https://hg.mozilla.org/releases/comm-aurora/rev/5a9e51058e4a
status-thunderbird45:
--- → fixed
status-thunderbird46:
--- → fixed
Comment 6•8 years ago
|
||
Sorry, didn't spot the typo "redable" in the commit message, neither did aleth for C-C (comment #2).
You need to log in
before you can comment on or make changes to this bug.
Description
•