623991 - White list Galaxy S phones to have OpenGL acceleration

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Whitelist galaxy s

Comment 2

[(no longer active)]

Comment on attachment 502069 [details] [diff] [review]
Whitelist galaxy s

r- because I've tried hw acceleration on my galaxy s for the past few days, and I must say that it's not usable for regular browsing, mostly because of random stuff being painted in random parts of the screen.  This will cause users not to be able to interact with web pages, or view them (because both the display and hit testing are broken), so I think enabling hw acceleration on Galaxy S in our current code shape would just prevent us from getting useful beta feedback from Galaxy S users.

Comment 3

[Stuart Parmenter]

HW acceleration works great on my Vibrant and Galaxy Tab, aside from a couple of bugs.  Is there anything special about your device?

Comment 4

[(no longer active)]

(In reply to comment #3)
> HW acceleration works great on my Vibrant and Galaxy Tab, aside from a couple
> of bugs.  Is there anything special about your device?

I don't think so.  It's a Vibrant Galaxy S with Froyo.  I have demonstrated some of the problems to Jeff in person...

Comment 5

[(no longer active)]

Comment on attachment 502069 [details] [diff] [review]
Whitelist galaxy s

r=me if we really feel comfortable moving forward with this (hint: I _don't_).

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Update slightly

Comment 7

[Jeff Muizelaar [:jrmuizel]]

http://hg.mozilla.org/mozilla-central/rev/8be020d87f83

Comment 8

[Jeff Muizelaar [:jrmuizel]]

This enabled gl everywhere because of this code in LayerManager Initialize:

  if (aExistingContext) {
    mGLContext = aExistingContext;
  } else {

So we don't hit the blacklist code.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

This should be working properly now:

http://hg.mozilla.org/mozilla-central/rev/0c0e26e7de8c