White list Galaxy S phones to have OpenGL acceleration

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

9 years ago
No description provided.
Assignee

Comment 1

9 years ago
Posted patch Whitelist galaxy s (obsolete) — Splinter Review

Comment 2

9 years ago
Comment on attachment 502069 [details] [diff] [review]
Whitelist galaxy s

r- because I've tried hw acceleration on my galaxy s for the past few days, and I must say that it's not usable for regular browsing, mostly because of random stuff being painted in random parts of the screen.  This will cause users not to be able to interact with web pages, or view them (because both the display and hit testing are broken), so I think enabling hw acceleration on Galaxy S in our current code shape would just prevent us from getting useful beta feedback from Galaxy S users.
Attachment #502069 - Flags: review-

Comment 3

9 years ago
HW acceleration works great on my Vibrant and Galaxy Tab, aside from a couple of bugs.  Is there anything special about your device?

Comment 4

9 years ago
(In reply to comment #3)
> HW acceleration works great on my Vibrant and Galaxy Tab, aside from a couple
> of bugs.  Is there anything special about your device?

I don't think so.  It's a Vibrant Galaxy S with Froyo.  I have demonstrated some of the problems to Jeff in person...

Comment 5

9 years ago
Comment on attachment 502069 [details] [diff] [review]
Whitelist galaxy s

r=me if we really feel comfortable moving forward with this (hint: I _don't_).
Attachment #502069 - Flags: review- → review+
Assignee

Comment 6

9 years ago
Attachment #502069 - Attachment is obsolete: true
Attachment #503062 - Flags: review?(ehsan)
Assignee

Comment 7

9 years ago
http://hg.mozilla.org/mozilla-central/rev/8be020d87f83
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee

Comment 8

9 years ago
This enabled gl everywhere because of this code in LayerManager Initialize:

  if (aExistingContext) {
    mGLContext = aExistingContext;
  } else {

So we don't hit the blacklist code.

Updated

9 years ago
Attachment #503062 - Flags: review?(ehsan)
Assignee

Comment 9

9 years ago
This should be working properly now:

http://hg.mozilla.org/mozilla-central/rev/0c0e26e7de8c
Assignee: nobody → jmuizelaar
You need to log in before you can comment on or make changes to this bug.