62419 - Can't prefill more than about 11 fields on a form

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[Stephen P. Morse]

1. Go to sample 3 form (tasks->privacy->form-manager->demo->sample 3
2. Fill in the following field:
    - shipping name
    - shipping address line 1
    - shipping address line 2
    - shipping city
    - shipping state
    - shipping zipcode
    - shipping dayphone
    - shipping nightphone
    - shipping email
    - billing address line 1
    - billing address line 2
    - billing city
    - billing state
    - billing zipcode
3. Capture the information (edit->save-form-data)
4. Reload the form
5. Prefill the form (edit->prefill-form)
6. Press OK.

DIALOG WITH PREVIEW OF VALUES GOES AWAY AND FORM PREFILLS.  THIS IS GOOD.

7. Reload the form
8. Prefill the form (edit->prefill-form)
9. Press OK.

NOTHING HAPPENS.  DIALOG WITH PREVIEW OF VALUES DOES NOT GO AWAY.  THIS IS BAD

At this time the console contains the following error message (repeated several 
times):

   chrome://communicator/content/wallet/WalletPreview.js line 132:
   menuList.selectedItem has no properties

Comment 1

[Stephen P. Morse]

Problem is caused by the fact that the last few menulists in the tree are 
scrolled off the screen.  The selectedItem for those menulists is coming up as 
undefined.

This used to work and there have been no changes to the wallet code in this area 
in a long time.  So this must be a regression in the xul code.

I have a simplified example that demonstrates the problem.  Will open a separate 
bug for that example and assign it to hyatt.

Comment 2

[Stephen P. Morse]

Simplified example is in bug 62420.

Comment 3

[Stephen P. Morse]

The best way to fix this is to get rid of trees on this dialog.  The only reason 
for the tree was to make the dialog scrollable if necessary.  I thought that the 
only way to accomplish scrolling was to use a tree (and maybe that was true when 
this dialog was originally written).  But now a much cleaner way to get 
scrolling is to put an overflow:auto on a box.

Taking this opportunity to get rid of some javascript warning messages as well 
(assignments to undeclared variables).

Comment 4

[Stephen P. Morse]

Attachment: patch to eliminate trees from this dialog

Comment 5

[Stephen P. Morse]

Attaching slightly better patch.  It uses read-only <textfield>s instead of 
<text>s so the user can scroll it if necessary.

Comment 6

[Stephen P. Morse]

Attachment: better patch -- uses <textfield>s instead of <text>

Comment 7

[dbragg]

As you've said you checked this out on multiple themes, I'll say it looks good
to me. r=dbragg

Comment 8

[Stephen P. Morse]

Message received from [e-mail] at Tue, 12 Dec 2000 16:12:24 -0800:

I am getting out of the business of super reviews, but I will grant you my last
one :-).  I looked this over and asked andreww to look at it as well.  

a=hangas

Comment 9

[Stephen P. Morse]

Fix checked in.