624255 - Ignored subthreads need visual feedback

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Karsten Düsterloh]

(Not sure yet if this is a mere SeaMonkey Classic issue or if backend changes are needed. Joshua might know. :) )

If you ignore a newsgroup thread, the thread starter icon gets a fat red forbidden sign painted over. In "show all threads incl. ignored" mode then you can tell which threads you killed and which not, empowering you to change that decision.

The same should hold for ignored subthreads, but doesn't: In "show all threads incl. ignored" mode, ignored substhreads are shown, but you can't tell whether a subthread is ignored or not.

Does the "subthread" state get propagated to the frontend at all?
- If not, it's MailNews Core bug.
- If so, we need theming changes.

Comment 1

[Karsten Düsterloh]

Downgrading to "major", because the perceived dataloss is only virtual due to lack of marking.

Comment 2

[Joshua Cranmer [:jcranmer]]

The DB view should be exposing it as an ignoreSubthread property, which should be set up in the CSS theme files.

Comment 3

[Karsten Düsterloh]

Yeah, using ignoreSubthread works, we "just" lack the imagery.

Comment 4

[Karsten Düsterloh]

Attachment: patch for classic theme

This adds missing icons for killed subthreads for Classic.

Since killed subthreads don't have thread column icons, this patch adds a forbidden sign to the subject column icon. Killed subthreads can't be new, so four new icons suffice.

I'm a bit puzzled by Modern: the icons there seem to be the same as the Classic ones, except that they are gifs and some(!) are only 16x14 — should I just use the new Classic png icons there as well?

Comment 5

[[e-mail]]

Comment on attachment 530189 [details] [diff] [review]
patch for classic theme

CSS changes look fine but the alpha channels of the images didn't show up in my image editor. Please verify them before you check in!

Comment 6

[[e-mail]]

(In reply to comment #4)
> I'm a bit puzzled by Modern: the icons there seem to be the same as the Classic
> ones, except that they are gifs and some(!) are only 16x14 — should I just use
> the new Classic png icons there as well?
Well, I guess when the Classic theme was "refreshed" its old gifs were ditched and Modern's gifs were converted (although why 32-bit PNGs?; message-news.gif is 193 bytes and message-news.png is 341 bytes but as a 4-bit PNG it would have been only 181 bytes, although a 4-bit GIF is even better at only 140 bytes). And the 16x14 is historical; assume that they will grow transparent borders.

So yes, you can use the same imagery in Modern, in your choice of format.

Comment 7

[Karsten Düsterloh]

Attachment: fix both themes [Checkin: comment 11]

This fixes both Classic and Modern, using the same icons. Transparency looks okay for me. The patch also shows the killed thread column icon for killed subthreads.

Comment 8

[[e-mail]]

(In reply to comment #6)
> although why 32-bit PNGs?
Although the "existing" Classic images are 32-bit RGBA, you had correctly attached 8-bit PNGs and my image editor has a different menu option to display the transparency in that case, which confused me :-(

Comment 9

[[e-mail]]

Comment on attachment 530449 [details] [diff] [review]
fix both themes [Checkin: comment 11]

Sorry, I don't like the thread pane changes. The rest is OK though.

Comment 10

[[e-mail]]

Comment on attachment 530449 [details] [diff] [review]
fix both themes [Checkin: comment 11]

As discussed on IRC, r=me without the threadCol changes.

Comment 11

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 530449 [details] [diff] [review]
fix both themes [Checkin: comment 11]

http://hg.mozilla.org/comm-central/rev/f1a8228296d3
http://hg.mozilla.org/releases/comm-2.0/rev/991a96598f5c

with comment 10 addressed, as requested by Karsten via IRC.

[I'm still wondering which encoding for the patch author name would have been correct. hg.mozilla.org (web) doesn't seem to like UTF-8. If you tell me what's right I'll take care next time.]

Comment 12

[Karsten Düsterloh]

> http://hg.mozilla.org/comm-central/rev/f1a8228296d3
> http://hg.mozilla.org/releases/comm-2.0/rev/991a96598f5c
> 
> with comment 10 addressed, as requested by Karsten via IRC.

Many thanks!

> [I'm still wondering which encoding for the patch author name would have
> been correct. hg.mozilla.org (web) doesn't seem to like UTF-8. If you tell
> me what's right I'll take care next time.]

UTF-8 should be okay.