Test file with underscore in its name does not get run by cfx test

RESOLVED FIXED

Status

Add-on SDK
Documentation
P2
normal
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: kumar, Assigned: wbamberg)

Tracking

({dev-doc-needed})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Steps to reproduce:
- Create a new package following the Add-on sdk tutorial at https://jetpack.mozillalabs.com/sdk/1.0b1/docs/#guide/getting-started
- Create a module
- Create a test file as tests/test_all.js that tests the module per tutorial
- run cfx test

Result:
0 of 0 tests pass

If you rename the file to tests/test-all.js then the test will run but I'd expect it to run as is since the file name starts with 'test'.

At the very least the documentation in the Tiny Test Suite part of the tutorial could be updated to point out this caveat https://jetpack.mozillalabs.com/sdk/1.0b1/docs/#guide/packaging
Let's document this!
Component: General → Documentation
Keywords: dev-doc-needed
Priority: -- → P3
QA Contact: general → documentation
Target Milestone: --- → 1.0
(automatic reprioritization of 1.0 bugs)
Priority: P3 → P2
Target Milestone: 1.0 → 1.1
(Pushing all open bugs to the --- milestone for the new triage system)
Target Milestone: 1.1 → ---
(Assignee)

Comment 4

6 years ago
Created attachment 569839 [details] [diff] [review]
Shockingly late patch
Assignee: nobody → wbamberg
Attachment #569839 - Flags: review?(dietrich)
Comment on attachment 569839 [details] [diff] [review]
Shockingly late patch

Review of attachment 569839 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the patch. should definitely land it. however, would be great to just support "test" as a prefix. but that's for another bug i guess.
Attachment #569839 - Flags: review?(dietrich) → review+
(Assignee)

Comment 6

6 years ago
Thanks Dietrich!
-> https://github.com/mozilla/addon-sdk/commit/2885fa151f40b43b8404718b999d7b35a98eb73b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.