624282 - Test file with underscore in its name does not get run by cfx test

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P2)

Description

[Kumar McMillan [:kumar]]

Steps to reproduce:
- Create a new package following the Add-on sdk tutorial at https://jetpack.mozillalabs.com/sdk/1.0b1/docs/#guide/getting-started
- Create a module
- Create a test file as tests/test_all.js that tests the module per tutorial
- run cfx test

Result:
0 of 0 tests pass

If you rename the file to tests/test-all.js then the test will run but I'd expect it to run as is since the file name starts with 'test'.

At the very least the documentation in the Tiny Test Suite part of the tutorial could be updated to point out this caveat https://jetpack.mozillalabs.com/sdk/1.0b1/docs/#guide/packaging

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Let's document this!

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(automatic reprioritization of 1.0 bugs)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 4

[Will Bamberg [:wbamberg]]

Attachment: Shockingly late patch

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 569839 [details] [diff] [review]
Shockingly late patch

Review of attachment 569839 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the patch. should definitely land it. however, would be great to just support "test" as a prefix. but that's for another bug i guess.

Comment 6

[Will Bamberg [:wbamberg]]

Thanks Dietrich!
-> https://github.com/mozilla/addon-sdk/commit/2885fa151f40b43b8404718b999d7b35a98eb73b