624315 - Identity display (for EV certs) is wrong when first load.

Status: VERIFIED DUPLICATE of bug 624514

(Core :: Security: PSM, defect)

Description

[Alice0775 White]

Build Identifier:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110109
Firefox/4.0b9pre ID:20110109030350

Identity display (for EV certs) is wrong when first load.
Duplication of the page helps to indicate correct Identity.
Reloading of the page does not help.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield
2. Clear cache (Ctril+Shilf+Del)
3. Restart Browser
4. Open URL
5. See Identity

6. Duplicate the tab (Middle click Reload Button)
7. See Identity

Actual Results:
 Blue Identity on the first load
 Green Identity on the second load

Expected Results:
 Green Identity on the first load

Comment 1

[Alice0775 White]

Attachment: screenshot

Comment 2

[Alice0775 White]

Regression window(cached hourly):
Works:
http://hg.mozilla.org/mozilla-central/rev/6f18c950b3b6
Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre ID:20110105155325
Fails:
http://hg.mozilla.org/mozilla-central/rev/d2856d5970b6
Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre ID:20110105163600
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6f18c950b3b6&tochange=d2856d5970b6

Regressed by:
d2856d5970b6	Dan Witte — Bug 580790 - Connection::initialize can access preferences off of the main thread. r=sdwilsh, sr=bsmedberg, a=betaN+

Comment 3

[Alice0775 White]

Sorry wrong Build Identifier in comment #0

Build Identifier:
Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20110109 Firefox/4.0b9pre ID:20110109030350

*This happens on ubuntu 10.04 and 8.04.
*This does not happen on Wndows 7 and XP.

Comment 4

[Alice0775 White]

This also happens on https://addons.mozilla.org/

Error shows in Error console:
Invalid use of the preferences on a background thread!

Comment 5

[Shawn Wilsher :sdwilsh]

Bug 619487 landed with the wrong commit message...

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Sounds like a PSM bug? :(

Comment 7

[Kaspar]

(In reply to comment #6)
> Sounds like a PSM bug? :(

Yes - chances are good that it'll go away once bug 585706 is fixed.

Currently, nsNSSCertificateDB::GetIsOcspOn can return somewhat "random" results (see bug 585706 comment 28), and EV status is only shown if PSM determines that OCSP is enabled (see http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsIdentityChecking.cpp#1019, in particular).

Comment 8

[Ben Bucksch (:BenB)]

We found PSM bug 624411, with stack. May be the same as this one.

Comment 9

[Kaspar]

(In reply to comment #8)
> We found PSM bug 624411, with stack. May be the same as this one.

Yes, very likely. Currently, you'll get the "Invalid use of the preferences on a background thread!" message whenever you connect to a new SSL site for the first time in a session - the AuthCertificateCallback calls  nsNSSCertificate::GetIsExtendedValidation for every cert (http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSCallbacks.cpp#1014 - afterwards the EV info is cached).

Comment 10

[Johnathan Nightingale [:johnath]]

I wouldn't pull the release off the wire for this bug, marking soft blocking, but if comment 7 is right about this being fixed by bug 585706, which is currently marked checkin-needed, can we... um... do that?

Comment 11

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

The patch that caused this regression was backed out before B9. I am working on a patch that fixes all the instances of PSM accessing nsIPrefService off the main thread in 624514.

Comment 12

[Honza Bambas (:mayhemer)]

According to comment 9 and comment 11, shouldn't this bug be closed?

Comment 13

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Yes. Resolving as duplicate of 624514.