Closed Bug 624345 Opened 9 years ago Closed 9 years ago

Fennec's About box should link to about:credits

Categories

(Firefox for Android Graveyard :: General, defect, P4, minor)

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: gerv, Assigned: gerv)

References

Details

Attachments

(1 file)

about:credits is the list of everyone in the past 13 years who has "made a significant investment of time, with useful results, into Mozilla project-governed activities", and has requested inclusion. As such, it is the best record of all the people who have made our codebase what it is today.

As such, every Mozilla-codebase project has a link to about:credits from its About box. We should make this true for Fennec also.

(This may be in addition to, or instead of, the Fennec-specific credits list. That's a policy decision for the Fennec developers. However, Firefox has recently eliminated their product-specific credits list in favour of just using about:credits for 4.0.)

Gerv
The current URL was created in bug 516691.

We can easily switch the link here:
http://mxr.mozilla.org/mobile-browser/source/app/mobile.js#413

Typing "about:credits" already works, but won't display because of bug 615223
Depends on: 615223
Adding Caitlin in case she has any thoughts on the mobile specific credits page. I am fine with just using the mozilla credits page.
Severity: normal → minor
Priority: -- → P4
I think "minor" is the wrong designation for this. Loads of people over the past 13 years have put in a boatload of effort to make the Mozilla platform (and therefore Fennec) possible, and I think it's reasonably important that there be a link to the list of their names as a minimal credit to them.

Given what mfinkle says, here's a patch which just switches the credit URL.

I think Fennec displays it OK, but if we wanted to add some mobile CSS to the credits page, I'd be very cool with that.

Gerv
Assignee: nobody → gerv
Status: NEW → ASSIGNED
Attachment #507197 - Flags: review?
Any updates about this bug?

If we keep about box, not switching to project-wide one, we must update mobile credits page (Bug 560247 ?):
http://www.mozilla.com/en-US/mobile/credits/
Attachment #507197 - Flags: review? → review?(mark.finkle)
Comment on attachment 507197 [details] [diff] [review]
Patch to change credits URL to project-wide credits list

If the project is moving toward a single credits page, then so should Fennec. The UI style should work fine on mobile screens.

Obviously we'll need to update the project credits page as most of the mobile team are missing from it.

Over to stuart for approval
Attachment #507197 - Flags: review?(mark.finkle)
Attachment #507197 - Flags: review+
Attachment #507197 - Flags: approval2.0?
Attachment #507197 - Flags: approval2.0? → approval2.0+
pushed:
http://hg.mozilla.org/mobile-browser/rev/cc31f390db6e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
VERIFIED FIXED on:
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110316
Firefox/4.0b13pre Fennec /4.0b6pre
Device: HTC Desire
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.