Closed
Bug 624404
Opened 15 years ago
Closed 15 years ago
Need test suite for exactgc.as and tracer macros
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P2)
Tamarin Graveyard
Garbage Collection (mmGC)
Tracking
(Not tracked)
RESOLVED
FIXED
Q3 11 - Serrano
People
(Reporter: lhansen, Assigned: lhansen)
References
Details
Attachments
(1 file)
|
6.33 KB,
patch
|
rulohani
:
review+
|
Details | Diff | Splinter Review |
There are macros / facilities that are not currently used but which were included for completeness (eg, the full _IF/_IFDEF/_IFNDEF set of macros). It would be good to have at least a basic smoke test for the facilities provided by exactgc.as, since it won't be fully tested by running on the code (certainly not the shell code).
| Assignee | ||
Updated•15 years ago
|
Priority: -- → P4
Target Milestone: --- → flash10.x-Serrano
| Assignee | ||
Updated•15 years ago
|
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•15 years ago
|
||
This is a header file that sits in core/. It is processed by the generator script and tracers are emitted into the standard place; the output can be visually inspected for correctness. There is an #ifdef wrapping the contents of the file so that the contents are inert during compilation.
Right now I only have a test in here for the preprocessor sniffer, since that's a facility that's new. We can expand that.
It would actually be useful for the contents of the file /not/ to be inert during compilation, because that way we could check for bugs in #ifdef handling more easily: same-name fields should only be present once; and fields should be referencable (from inline functions, say). Something to think about for a second pass.
Attachment #524083 -
Flags: review?(rulohani)
Updated•15 years ago
|
Attachment #524083 -
Flags: review?(rulohani) → review+
| Assignee | ||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 2•15 years ago
|
||
changeset: 6171:48ada9af5215
user: Lars T Hansen <lhansen@adobe.com>
summary: Fix 624404 - Need test suite for exactgc.as and tracer macros (r=rulohani), somewhat extended
http://hg.mozilla.org/tamarin-redux/rev/48ada9af5215
You need to log in
before you can comment on or make changes to this bug.
Description
•