Closed Bug 624536 Opened 9 years ago Closed 9 years ago

Uninstalling personas addons does not disable personas themes from addons manager

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set

Tracking

(fennec2.0+)

VERIFIED FIXED
Tracking Status
fennec 2.0+ ---

People

(Reporter: tchung, Assigned: fabrice)

Details

Attachments

(2 files)

If personas addon is uninstalled, we should not allow any user action on the downloaded persona themes.   I recommend disabling the theme options (Enable/Disable/Uninstall) until it detects personas addon is installed again.  

Repro:
1) install android nightly trunk: Mozilla/5.0 (Android; Linux armv71; rv:2.0b9pre) Gecko/20110110 Firefox/4.0b9pre Fennec/4.0b4pre	
2) install personas addon
3) download a handful of personas from getpersonas.com
4) now uninstall personas addon
5) Verify the downloaded personas themes all still have enabled buttons in addons manager to enable/disable/uninstall.   We should disable this since the personas addon is uninstalled.

Expected:
- downloaded personas gets grayed out buttons if personas is unistalled

ActuaL:
- buttons are active, but they do nothing cause the extension is uninstalled.
And as expected, the warning to go with this behavior.

WARN addons.xpi: Unable to activate the default theme
resource://gre/modules/XPIProvider.jsm
2661
Attached patch patchSplinter Review
This patch disables all buttons if we find an add-on from @personas.mozilla.org but the persona add-on itself is not installed.
Assignee: nobody → fabrice
Attachment #502686 - Flags: review?(mark.finkle)
Comment on attachment 502686 [details] [diff] [review]
patch

I was worried about this patch being to explicit, but it seems "@personas.mozilla.org" is is used by the LightweightThemeManager and LightWeightThemeWebInstaller will be the name of the helper object when we port personas to Fennec too.

I'm OK with this change. We can remove it after we port personas to Fennec.
Attachment #502686 - Flags: review?(mark.finkle) → review+
tracking-fennec: --- → 2.0+
Keywords: checkin-needed
pushed:
http://hg.mozilla.org/mobile-browser/rev/95e408a37dbb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
VERIFIED FIXED on Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b9pre)
Gecko/20110111 Firefox/4.0b9pre Fennec /4.0b4pre

Device: Motorola Droid 2 (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.