624562 - The notifications API should warn and use the default icon when an invalid iconURL is given

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

bsterne had a problem where the URL returned from self.data.url was wrong, and passing that URL as the iconURL to the notifications API gave him this unhelpful error rather than showing the notification:

[Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIAlertsService.showAlertNotification]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://jid0-qjdoz32n3dcx6vs5qztj6sfouq8-jetpack-core-lib/securable-module.js -> resource://jid0-qjdoz32n3dcx6vs5qztj6sfouq8-jetpack-core-lib/notifications.js :: notifications_notify :: line 58"  data: no]

He could have just as easily made a simple typo in the filename.

If the iconURL is invalid, the user should get a helpful warning, the notification should happen, and the default icon should be used.

Comment 1

[Drew Willcoxon :adw]

Thanks for the quick review.

https://github.com/mozilla/addon-sdk/commit/6dbaafa464741974326af4cd6ce36a97e6f11ffa