624615 - Img src tag auto-links incorrectly in Description field

Status: RESOLVED INVALID

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

In the "Description" field on https://addons.allizom.org/z/en-US/developers/addon/a9-9331/edit, I have only the following:

<img src="http://www.bestcarsguide.com/wp-content/uploads/2010/10/lexus-is-f.jpg">

It auto-links that as:

https://outgoing.stage.mozilla.com/v1/58bf71036b302f37e9f5139a306760de99d5790f/http%3A//www.bestcarsguide.com/wp-content/uploads/2010/10/lexus-is-f.jpg%22%3E

When it should be (omitted the outgoing.* for readability here):

http://www.bestcarsguide.com/wp-content/uploads/2010/10/lexus-is-f.jpg

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot, for posterity

Comment 2

[Jeff Balogh (:jbalogh)]

img tags aren't allowed. Down that road lies myspace.

Comment 3

[Justin Scott [:fligtar]]

I think you mean my[_____]

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #2)
> img tags aren't allowed. Down that road lies myspace.

Since they're not allowed, I don't understand why we auto-link that type, albeit incorrectly.

Comment 5

[Jeff Balogh (:jbalogh)]

(In reply to comment #4)
> (In reply to comment #2)
> > img tags aren't allowed. Down that road lies myspace.
> 
> Since they're not allowed, I don't understand why we auto-link that type,
> albeit incorrectly.

I think the linkifier is the last thing to go over the text, so the <img > has already been converted into escaped &lt;img &gt;. To the linkifier it all looks like text.