624625 - change home page of Google search plugin to google.com

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Frank Yan (:fryn)]

We want to eliminate all dependencies on google.com/firefox .
For example, clicking the Google label on the newly streamlined search field should bring up google.com not google.com/firefox .

Changing
https://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/google.xml#16
to:
<SearchForm>http://www.google.com/</SearchForm>
only fixes it for en-US. What else would we need to fix this for other locales?

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

We can update this after we ship, technically ...

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> Changing
> https://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/google.xml#16
> to:
> <SearchForm>http://www.google.com/</SearchForm>
> only fixes it for en-US.

No, it fixes it everywhere - we use the en-US google.xml for all locales.

(In reply to comment #1)
> We can update this after we ship, technically ...

No, we can't - we can't yet update app-shipped engines.

Comment 3

[Frank Yan (:fryn)]

Attachment: patch

(In reply to comment #2)
> (In reply to comment #1)
> > We can update this after we ship, technically ...
> 
> No, we can't - we can't yet update app-shipped engines.

Oh :(
Well, here's the simple patch to update the URL for new users.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 502723 [details] [diff] [review]
patch

This also updates it for existing users.

Comment 5

[Alexander L. Slovesnik]

(In reply to comment #2)
> No, it fixes it everywhere - we use the en-US google.xml for all locales.
Except Kurdish. Kurdish uses separate google-ku.xml (which was added in Bug 449112).

Comment 6

[Axel Hecht [:Pike]]

... and for ja/ja-JP-mac

Comment 7

[Frank Yan (:fryn)]

I got this list:

https://mxr.mozilla.org/l10n-central/search?string=%3CSearchForm%3Ehttp%3A%2F%2Fwww.google&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central

If we need to update these, I can do that too, if the process of pushing to l20n-central is just as simple as pushing to mozilla-central.

Comment 8

[Axel Hecht [:Pike]]

Anything that's named google.xml isn't picked up by the build. The search engine packaging is checking the en-US directory for plugins first, and then l10n, so anything referencing plain "google.xml" will always get the en-US version.

We occasionally harrass people to remove the copies, but that's only mildly successful, as you can see.

Also, your search includes mobile, which this bug isn't about, AFAICT.

For the process, no, you can't just push to l10n-central. All the locales that need fixes (two, still, AFAICT), need individual bugs filed to make sure they know what's happening to their code.

Comment 9

[Frank Yan (:fryn)]

Pushed and filed the individual bugs for ku and ja/ja-JP-mac.

http://hg.mozilla.org/mozilla-central/rev/05007aad7d2b