Closed Bug 624625 Opened 9 years ago Closed 9 years ago

change home page of Google search plugin to google.com

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b10
Tracking Status
blocking2.0 --- final+

People

(Reporter: fryn, Assigned: fryn)

References

Details

Attachments

(1 file)

We want to eliminate all dependencies on google.com/firefox .
For example, clicking the Google label on the newly streamlined search field should bring up google.com not google.com/firefox .

Changing
https://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/google.xml#16
to:
<SearchForm>http://www.google.com/</SearchForm>
only fixes it for en-US. What else would we need to fix this for other locales?
blocking2.0: --- → ?
OS: Mac OS X → All
Hardware: x86 → All
We can update this after we ship, technically ...
(In reply to comment #0)
> Changing
> https://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/google.xml#16
> to:
> <SearchForm>http://www.google.com/</SearchForm>
> only fixes it for en-US.

No, it fixes it everywhere - we use the en-US google.xml for all locales.

(In reply to comment #1)
> We can update this after we ship, technically ...

No, we can't - we can't yet update app-shipped engines.
blocking2.0: ? → final+
Attached patch patchSplinter Review
(In reply to comment #2)
> (In reply to comment #1)
> > We can update this after we ship, technically ...
> 
> No, we can't - we can't yet update app-shipped engines.

Oh :(
Well, here's the simple patch to update the URL for new users.
Comment on attachment 502723 [details] [diff] [review]
patch

This also updates it for existing users.
Attachment #502723 - Flags: review+
Attachment #502723 - Attachment description: patch to update it for new users → patch
Assignee: nobody → fryn
Status: NEW → ASSIGNED
(In reply to comment #2)
> No, it fixes it everywhere - we use the en-US google.xml for all locales.
Except Kurdish. Kurdish uses separate google-ku.xml (which was added in Bug 449112).
... and for ja/ja-JP-mac
I got this list:

https://mxr.mozilla.org/l10n-central/search?string=%3CSearchForm%3Ehttp%3A%2F%2Fwww.google&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central

If we need to update these, I can do that too, if the process of pushing to l20n-central is just as simple as pushing to mozilla-central.
Anything that's named google.xml isn't picked up by the build. The search engine packaging is checking the en-US directory for plugins first, and then l10n, so anything referencing plain "google.xml" will always get the en-US version.

We occasionally harrass people to remove the copies, but that's only mildly successful, as you can see.

Also, your search includes mobile, which this bug isn't about, AFAICT.

For the process, no, you can't just push to l10n-central. All the locales that need fixes (two, still, AFAICT), need individual bugs filed to make sure they know what's happening to their code.
Blocks: 624956
Blocks: 624957
Pushed and filed the individual bugs for ku and ja/ja-JP-mac.

http://hg.mozilla.org/mozilla-central/rev/05007aad7d2b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
You need to log in before you can comment on or make changes to this bug.