Closed
Bug 624696
Opened 15 years ago
Closed 15 years ago
Need new template hook to add parameter description
Categories
(Bugzilla :: Extensions, enhancement)
Bugzilla
Extensions
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: aliustek, Assigned: aliustek)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.65 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-GB; rv:1.9.2.13) Gecko/20101206 Ubuntu/10.10 (maverick) Firefox/3.6.13
Build Identifier:
There should be a template hook in support of config_modify_panels hook to add/modify parameter description
Reproducible: Always
Attachment #502790 -
Flags: review?
|
||
Comment 2•15 years ago
|
||
You should ask mkanat for review.
Assignee: user-accounts → aliustek
Status: UNCONFIRMED → NEW
Component: Administration → Extensions
Ever confirmed: true
OS: Linux → All
Hardware: x86_64 → All
Summary: Request: Need new template hook to add parameter description → Need new template hook to add parameter description
Target Milestone: --- → Bugzilla 4.2
Attachment #502790 -
Flags: review? → review?(mkanat)
Moved template file to hook folder
Attachment #502790 -
Attachment is obsolete: true
Attachment #503118 -
Flags: review?(mkanat)
Attachment #502790 -
Flags: review?(mkanat)
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 503118 [details] [diff] [review]
Parameter Description Hook
Hmm. I think having to do the "FOREACH panel IN panels" is more complexity than we want. How about we run the template hook only for the current panel? So, inside of the "IF panel.current" block. Then we can call it current_panel.
Attachment #503118 -
Flags: review?(mkanat) → review-
Moved hook to within current panel and renamed it to current_panel
Attachment #503118 -
Attachment is obsolete: true
Attachment #505735 -
Flags: review?(mkanat)
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 505735 [details] [diff] [review]
Template-Hook-current_panel
Looks good to me. :-)
Attachment #505735 -
Flags: review?(mkanat) → review+
|
|
||
Updated•15 years ago
|
Flags: approval4.0+
Flags: approval+
Target Milestone: Bugzilla 4.2 → Bugzilla 4.0
|
|
||
Comment 7•15 years ago
|
||
This bug requires bug 624349 to work, which landed in 4.1 only.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified extensions/Example/Extension.pm
added extensions/Example/template/en/default/hook/admin/params
added extensions/Example/template/en/default/hook/admin/params/editparams-current_panel.html.tmpl
modified template/en/default/admin/params/editparams.html.tmpl
Committed revision 7663.
Status: NEW → RESOLVED
Closed: 15 years ago
Depends on: 624349
Flags: approval4.0+ → approval4.0-
Resolution: --- → FIXED
Target Milestone: Bugzilla 4.0 → Bugzilla 4.2
You need to log in
before you can comment on or make changes to this bug.
Description
•