Closed
Bug 624734
Opened 13 years ago
Closed 13 years ago
Star UI has no tooltip until bookmarked page is visited
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 4.0b10
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: neil, Assigned: Unfocused)
References
Details
(Keywords: regression, Whiteboard: [hardblocker][has patch])
Attachments
(1 file)
3.07 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce problem: 1. Set the home page to a page that is not bookmarked 2. Restart the browser 3. Note that the Star has no tooltip 4. Navigate to a bookmarked page 5. Note that the Star has a tooltip 6. Navigate to an unbookmarked page 7. Note that the Star has a tooltip Expected result: Star tooltip at step 3 is the same as step 7. There's a related version of this bug where visiting about:blank leaves the Star and its tooltip in its previous state.
Reporter | ||
Comment 1•13 years ago
|
||
(In reply to comment #0) > There's a related version of this bug where visiting about:blank leaves the > Star and its tooltip in its previous state. This is worse than I thought; simply opening a new tab triggers that bug...
Assignee | ||
Comment 3•13 years ago
|
||
Yoink!
Assignee: margaret.leibovic → bmcbride
Status: NEW → ASSIGNED
Updated•13 years ago
|
Keywords: regression
Whiteboard: [hardblocker]
Comment 4•13 years ago
|
||
[hardblocker] because it is a regression? I'm not sure this should even be a blocker since it only involves a tooltip.
Assignee | ||
Comment 5•13 years ago
|
||
Marco: You mentioned about maybe needing to special-case about:blank, but AFAICT that isn't needed. Or am I missing something?
Attachment #503397 -
Flags: review?(mak77)
Comment 6•13 years ago
|
||
I was referring to the end of comment 0 and comment 1, but we don't show any star on about:blank. Neil, is that a specific Seamonkey problem? maybe you don't want the about:blank early return if you show the star, or you want to hide the star as well.
Reporter | ||
Comment 7•13 years ago
|
||
(In reply to comment #6) > I was referring to the end of comment 0 and comment 1, but we don't show any > star on about:blank. Ah, I hadn't realised you had extra CSS to hide stuff when the page proxy state is invalid (although in SeaMonkey, about:blank isn't an invalid page unless it's the first page in session history).
Updated•13 years ago
|
Attachment #503397 -
Flags: review?(mak77) → review+
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite+
Flags: in-litmus-
Keywords: checkin-needed
Whiteboard: [hardblocker] → [hardblocker][has patch][needs landing]
Comment 8•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2a6689064703
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [hardblocker][has patch][needs landing] → [hardblocker][has patch]
Target Milestone: --- → Firefox 4.0b10
You need to log in
before you can comment on or make changes to this bug.
Description
•