Last Comment Bug 624742 - Places shouldn't use nsDependentString to convert an nsAString to an nsString
: Places shouldn't use nsDependentString to convert an nsAString to an nsString
Status: RESOLVED FIXED
[good first bug][mentor=jdm][inbound]
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Edgar Flores
:
Mentors:
http://mxr.mozilla.org/mozilla-centra...
Depends on:
Blocks: 568925 624738
  Show dependency treegraph
 
Reported: 2011-01-11 08:35 PST by neil@parkwaycc.co.uk
Modified: 2011-08-06 02:49 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Changed nsDependentString call to nsString (986 bytes, patch)
2011-08-04 11:34 PDT, Edgar Flores
mak77: review+
Details | Diff | Splinter Review

Description neil@parkwaycc.co.uk 2011-01-11 08:35:50 PST
Just use nsString, or maybe PromiseFlatString.
Comment 1 Josh Matthews [:jdm] 2011-04-10 11:34:37 PDT
Relevant code is in the URL field.
Comment 2 Edgar Flores 2011-08-04 10:18:04 PDT
I'm interested in taking this up and I think I made the correct change in History.cpp. How do I proceed?
Comment 3 Josh Matthews [:jdm] 2011-08-04 10:26:32 PDT
You'll want to follow the directions at https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f for generating the patch, then attach it here via the "Add an attachment link".
Comment 4 Edgar Flores 2011-08-04 11:34:35 PDT
Created attachment 550763 [details] [diff] [review]
Changed nsDependentString call to nsString
Comment 5 Marco Bonardo [::mak] 2011-08-04 16:42:02 PDT
Comment on attachment 550763 [details] [diff] [review]
Changed nsDependentString call to nsString

Review of attachment 550763 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, and congrats for your fist patch!
you may add a checkin-needed keyword to this bug to have someone push your patch to the repository
Comment 6 Edgar Flores 2011-08-04 17:01:41 PDT
Thanks!!
Comment 8 Marco Bonardo [::mak] 2011-08-06 02:49:49 PDT
http://hg.mozilla.org/mozilla-central/rev/d68a492dcabe

Note You need to log in before you can comment on or make changes to this bug.