Places shouldn't use nsDependentString to convert an nsAString to an nsString

RESOLVED FIXED in mozilla8

Status

()

Core
IPC
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: Edgar Flores)

Tracking

Trunk
mozilla8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=jdm][inbound], URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Just use nsString, or maybe PromiseFlatString.

Comment 1

6 years ago
Relevant code is in the URL field.

Updated

6 years ago
Whiteboard: [good first bug] → [good first bug][mentor=jdm]
(Assignee)

Comment 2

6 years ago
I'm interested in taking this up and I think I made the correct change in History.cpp. How do I proceed?

Comment 3

6 years ago
You'll want to follow the directions at https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f for generating the patch, then attach it here via the "Add an attachment link".
(Assignee)

Comment 4

6 years ago
Created attachment 550763 [details] [diff] [review]
Changed nsDependentString call to nsString

Updated

6 years ago
Attachment #550763 - Flags: review?(mak77)
Comment on attachment 550763 [details] [diff] [review]
Changed nsDependentString call to nsString

Review of attachment 550763 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, and congrats for your fist patch!
you may add a checkin-needed keyword to this bug to have someone push your patch to the repository
Attachment #550763 - Flags: review?(mak77) → review+
(Assignee)

Comment 6

6 years ago
Thanks!!
(Reporter)

Updated

6 years ago
Assignee: nobody → edgarf2002
Keywords: checkin-needed

Comment 7

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/d68a492dcabe
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=jdm] → [good first bug][mentor=jdm][inbound]
http://hg.mozilla.org/mozilla-central/rev/d68a492dcabe
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.