Closed Bug 624742 Opened 9 years ago Closed 8 years ago

Places shouldn't use nsDependentString to convert an nsAString to an nsString

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: neil, Assigned: edgarf2002)

References

()

Details

(Whiteboard: [good first bug][mentor=jdm][inbound])

Attachments

(1 file)

Just use nsString, or maybe PromiseFlatString.
Relevant code is in the URL field.
Whiteboard: [good first bug] → [good first bug][mentor=jdm]
I'm interested in taking this up and I think I made the correct change in History.cpp. How do I proceed?
You'll want to follow the directions at https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f for generating the patch, then attach it here via the "Add an attachment link".
Attachment #550763 - Flags: review?(mak77)
Comment on attachment 550763 [details] [diff] [review]
Changed nsDependentString call to nsString

Review of attachment 550763 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, and congrats for your fist patch!
you may add a checkin-needed keyword to this bug to have someone push your patch to the repository
Attachment #550763 - Flags: review?(mak77) → review+
Thanks!!
Assignee: nobody → edgarf2002
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/d68a492dcabe
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=jdm] → [good first bug][mentor=jdm][inbound]
http://hg.mozilla.org/mozilla-central/rev/d68a492dcabe
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.