nsBidiPresUtils should not keep state as member variables

RESOLVED FIXED

Status

()

Core
Layout: Text
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: smontagu)

Tracking

(Blocks: 1 bug)

Other Branch
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

See bug 624722 comment 4.
(Assignee)

Comment 1

7 years ago
Created attachment 519654 [details] [diff] [review]
Patch

This applies on top of the patches in bug 263359
Assignee: nobody → smontagu
Status: NEW → ASSIGNED
Attachment #519654 - Flags: review?(roc)
Comment on attachment 519654 [details] [diff] [review]
Patch

This review is a bit rubber-stamp-y but it looks good to me.

+  nsBidi*             mBidiEngine;

nsAutoPtr

Some of the nsTArrays should probably be nsAutoTArray.
(Assignee)

Comment 3

7 years ago
Created attachment 523097 [details] [diff] [review]
Patch v.2. updated to tip and to comments
Attachment #519654 - Attachment is obsolete: true
Attachment #523097 - Flags: review?(roc)
Attachment #519654 - Flags: review?(roc)
Attachment #523097 - Flags: review?(roc) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/ad5009233ae9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Version: Trunk → Other Branch
Depends on: 651229
(Assignee)

Comment 5

6 years ago
Backed out in http://hg.mozilla.org/mozilla-central/rev/fa0295a97f1b because of bug 650189
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

6 years ago
Blocks: 566066
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/mozilla-central/rev/b529ffc1012b
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.