Closed Bug 624798 Opened 9 years ago Closed 9 years ago

nsBidiPresUtils should not keep state as member variables

Categories

(Core :: Layout: Text and Fonts, defect)

Other Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ehsan, Assigned: smontagu)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

See bug 624722 comment 4.
Attached patch Patch (obsolete) — Splinter Review
This applies on top of the patches in bug 263359
Assignee: nobody → smontagu
Status: NEW → ASSIGNED
Attachment #519654 - Flags: review?(roc)
Comment on attachment 519654 [details] [diff] [review]
Patch

This review is a bit rubber-stamp-y but it looks good to me.

+  nsBidi*             mBidiEngine;

nsAutoPtr

Some of the nsTArrays should probably be nsAutoTArray.
Attachment #519654 - Attachment is obsolete: true
Attachment #523097 - Flags: review?(roc)
Attachment #519654 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/ad5009233ae9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Version: Trunk → Other Branch
Depends on: 651229
Backed out in http://hg.mozilla.org/mozilla-central/rev/fa0295a97f1b because of bug 650189
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 566066
http://hg.mozilla.org/mozilla-central/rev/b529ffc1012b
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.