624837 - Pages don't load with "Use system proxy settings" and system SOCKS proxy defined

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Brandon Siegel]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8) Gecko/20100101 Firefox/4.0b8

With Firefox 4.0b8 and Windows 7 x64, if I set Firefox to "Use system proxy settings" and then specify a SOCKS proxy in the Internet control panel, no pages will load. With the same Firefox setting, if I turn off the use of a proxy in the Internet control panel, pages load fine though obviously not through the proxy. If I set Firefox to "Manual proxy configuration" and specify the same SOCKS proxy as before, pages load fine through the proxy.

Reproducible: Always

Steps to Reproduce:
1. Enable use of a system SOCKS proxy in Windows's Internet Options control panel -> Connections -> LAN Settings.
2. Do not modify the Address and Port fields on this form - instead, click the Advanced button and specify a valid SOCKS proxy. For testing, I am using an SSH tunnel with "ssh -N -D 9050 ...". Do not specify any other type of proxy.
3. Set Firefox to use the system proxy settings in Options -> Advanced -> Network -> Settings... -> Use system proxy settings
4. Try to load any page. 
Actual Results:  
No pages will load.

Expected Results:  
Pages should load through the system-defined SOCKS proxy.

Using public 32-bit release of 4.0b8 on Windows 7 x64 OS. Buildconfig is:

Source

Built from http://hg.mozilla.org/mozilla-central/rev/d78f9cb65e91
Build platform
target
i686-pc-mingw32
Build tools
Compiler 	Version 	Compiler flags
d;D:\mozilla-build\msys\mozilla-build\python25\python2.5.exe -O e;D:\mozilla-build\msys\builds\moz2_slave\rel-cen-w32-bld\build\build\cl.py cl 	14.00.50727.762 	-TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
d;D:\mozilla-build\msys\mozilla-build\python25\python2.5.exe -O e;D:\mozilla-build\msys\builds\moz2_slave\rel-cen-w32-bld\build\build\cl.py cl 	14.00.50727.762 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800 -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
Configure arguments

--enable-application=browser --enable-update-channel=beta --enable-update-packaging --enable-jemalloc --enable-tests --enable-official-branding

Comment 1

[Bjarne (:bjarne)]

Special case of bug #513663 but for Windows?

Comment 2

[Wayne Mery (:wsmwk)]

Brandon, did this work for you in version 3.6?

Comment 3

[Brandon Siegel]

(In reply to comment #2)
> Brandon, did this work for you in version 3.6?

Tested with FFx 3.6.11, it is broken there too.

Comment 4

[jgs-mozilla]

Same issue exists with Mac OS X. I opened https://bugzilla.mozilla.org/show_bug.cgi?id=840159, which is largely a copy of this bug.

Comment 6

[hujq]

This bug still exists for me with
Firefox 38.0 beta 9 20150429135941 (user-agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Firefox/38.0)
on
OS X 10.10.3 (14D136).

Comment 7

[sid]

And in Firefox 53 on Windows 10 too it fails too.

Comment 8

[Gary Chen [:xeonchen]]

Attachment: Bug 624837 - use calculated string length instead of magic number;

The original magic number is incorrect.

Review commit: https://reviewboard.mozilla.org/r/149014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149014/

Comment 9

[Daniel Stenberg [:bagder]]

Comment on attachment 8877543 [details]
Bug 624837 - use calculated string length instead of magic number;

https://reviewboard.mozilla.org/r/149014/#review153918

Nice find and fix!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f5aa38c6cec
use calculated string length instead of magic number; r=bagder

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9f5aa38c6cec

Comment 12

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 13

[Gary Chen [:xeonchen]]

(In reply to Mozilla Autoland from comment #12)
> We're sorry - something has gone wrong while rewriting or rebasing your
> commits. The commits being pushed no longer match what was requested. Please
> file a bug.

Oops, my fault.

Comment 14

[Andrea Guglielmi]

Sorry, I didn't understand if this bug is really fixed as latest nightly (Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 ID:20171105220721) seems to have the same bug.

Thanks.

Comment 15

[Shian-Yow Wu [:swu]]

Ni? to make sure Gary sees comment 14.

Comment 16

[Gary Chen [:xeonchen]]

(In reply to Andrea Guglielmi from comment #14)
> Sorry, I didn't understand if this bug is really fixed as latest nightly
> (Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101
> Firefox/58.0 ID:20171105220721) seems to have the same bug.
> 
> Thanks.

Yes, this has been fixed in rv56. So I'd think it might be another issue.
Are your reproduce steps identical to the bug's description or you have different steps?

Comment 17

[Andrea Guglielmi]

(In reply to Gary Chen [:xeonchen] (needinfo plz) from comment #16)
> Yes, this has been fixed in rv56. So I'd think it might be another issue.
> Are your reproduce steps identical to the bug's description or you have
> different steps?
Hi Gary, this is my test:
I'm on a customer site and I must use a proxy server but I found that web.whatsapp.com was not working no matter the browser I used. I double checked Windows Internet Settings (forget about NetSetMan Pro) and found that proxy setting for the SOCKS protocol was missing, so I put the missing values and FF was still not working but...voilà...IE/Edge did it.
After checking FF proxy settings I switched from System to Manual settings, set all the values for every protocol and web.whatsapp.com was finally reachable from FF too.

I'm just an average user, I don't know the corporate proxy software and I don't know if it is normal that web.whatsapp uses SOCKS protocol...but it is clear for me that Nightly didn't read SOCKS setting from Windows Internet settings panel.

If you have a test I can do just let me know it.

Comment 18

[Gary Chen [:xeonchen]]

(also ni? myself to have a test on Windows.)

(In reply to Andrea Guglielmi from comment #17)
> Hi Gary, this is my test:
> I'm on a customer site and I must use a proxy server but I found that
> web.whatsapp.com was not working no matter the browser I used. I double
> checked Windows Internet Settings (forget about NetSetMan Pro) and found
> that proxy setting for the SOCKS protocol was missing, so I put the missing
> values and FF was still not working but...voilà...IE/Edge did it.

You set only SOCKS setting in Windows Internet Settings.

> After checking FF proxy settings I switched from System to Manual settings,
> set all the values for every protocol and web.whatsapp.com was finally
> reachable from FF too.

And set all protocol in Firefox network settings here.
Did it work if you set only SOCKS setting (remove http/ssl/ftp settings) in Firefox?

> I'm just an average user, I don't know the corporate proxy software and I
> don't know if it is normal that web.whatsapp uses SOCKS protocol...but it is
> clear for me that Nightly didn't read SOCKS setting from Windows Internet
> settings panel.
> 
> If you have a test I can do just let me know it.

Thank you for you help, I'll let you know if I need more information.

Comment 19

[Andrea Guglielmi]

(In reply to Gary Chen [:xeonchen] (needinfo plz) from comment #18)
> (also ni? myself to have a test on Windows.)
> 
> (In reply to Andrea Guglielmi from comment #17)
> > Hi Gary, this is my test:
> > I'm on a customer site and I must use a proxy server but I found that
> > web.whatsapp.com was not working no matter the browser I used. I double
> > checked Windows Internet Settings (forget about NetSetMan Pro) and found
> > that proxy setting for the SOCKS protocol was missing, so I put the missing
> > values and FF was still not working but...voilà...IE/Edge did it.
> 
> You set only SOCKS setting in Windows Internet Settings.

No, I added socks settings to others (HTTP, SSL and FTP)

> > After checking FF proxy settings I switched from System to Manual settings,
> > set all the values for every protocol and web.whatsapp.com was finally
> > reachable from FF too.
> 
> And set all protocol in Firefox network settings here.
> Did it work if you set only SOCKS setting (remove http/ssl/ftp settings) in
> Firefox?

As I wrote, ALL protocols on Internet Settings and ALL protocols on FF.

> Thank you for you help, I'll let you know if I need more information.

You're welcome

Comment 20

[Gary Chen [:xeonchen]]

(In reply to Andrea Guglielmi from comment #19)
> (In reply to Gary Chen [:xeonchen] (needinfo plz) from comment #18)
> > (also ni? myself to have a test on Windows.)
> > 
> > (In reply to Andrea Guglielmi from comment #17)
> > > Hi Gary, this is my test:
> > > I'm on a customer site and I must use a proxy server but I found that
> > > web.whatsapp.com was not working no matter the browser I used. I double
> > > checked Windows Internet Settings (forget about NetSetMan Pro) and found
> > > that proxy setting for the SOCKS protocol was missing, so I put the missing
> > > values and FF was still not working but...voilà...IE/Edge did it.
> > 
> > You set only SOCKS setting in Windows Internet Settings.
> 
> No, I added socks settings to others (HTTP, SSL and FTP)

It could be the problem.
SOCKS protocol is different from HTTP/HTTPS proxy, so it goes error if you fill SOCKS proxy server into HTTP field.

If you want to specific use SOCKS proxy, you should leave other types empty.

> > > After checking FF proxy settings I switched from System to Manual settings,
> > > set all the values for every protocol and web.whatsapp.com was finally
> > > reachable from FF too.
> > 
> > And set all protocol in Firefox network settings here.
> > Did it work if you set only SOCKS setting (remove http/ssl/ftp settings) in
> > Firefox?
> 
> As I wrote, ALL protocols on Internet Settings and ALL protocols on FF.
> 
> > Thank you for you help, I'll let you know if I need more information.
> 
> You're welcome

Comment 21

[Gary Chen [:xeonchen]]

I just realized in Windows 10, you have to fill "socks=<proxy>" (e.g. "socks=127.0.0.1") in the host field.
Otherwise it will be set for http/ssl/ftp proxy.

Comment 22

[kiddyfurby]

I use a SOCKS proxy, and its in my macOS network -> Wi-Fi -> Advanced -> Proxies -> SOCKS proxy
The default Firefox settings of "Use system proxy settings" does not work.
If I try to access any URL Firefox would be loading forever.

If I manually enter my socks settings into "Manual proxy configuration" then Firefox works.

Comment 23

[Gary Chen [:xeonchen]]

(In reply to kiddyfurby from comment #22)
> I use a SOCKS proxy, and its in my macOS network -> Wi-Fi -> Advanced ->
> Proxies -> SOCKS proxy
> The default Firefox settings of "Use system proxy settings" does not work.
> If I try to access any URL Firefox would be loading forever.
> 
> If I manually enter my socks settings into "Manual proxy configuration" then
> Firefox works.

Hi, I cannot reproduce your issue, I think this would be another issue, please file a new bug with reproduce steps.