Closed Bug 624894 Opened 9 years ago Closed 9 years ago

Allow syncing of prefs in fennec

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Future

People

(Reporter: tchung, Assigned: mbrubeck)

References

Details

Attachments

(1 file)

Marking future.

It would be great to have firefox desktop sync users' personas settings and themes to fennec.  This would make sense if we decide to integrate lightweight theming.   But if we can do something simple with the personas addon, that would be cool too.

Repro:
1) install fennec future
2) on desktop firefox, sync a set of lightweight theme json data to fennec
3) Verify the personas theme gets adopted
Target Milestone: --- → Future
OS: Android → All
Hardware: ARM → All
According to philikon, we can set the pref("services.sync.prefs.sync.lightweightThemes.usedThemes", true) to enable this behavior.

Here are some other preferences synced for desktop Firefox; we should consider which ones to sync for Fennec:
http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#959
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
This patch enables preference sync for Fennec.  The list of synced prefs includes all the main user-controlled ones, and a subset of the desktop list that makes sense on Fennec.

Preference sync is per-app, so these prefs will *not* sync between desktop and mobile.  They will only sync from one mobile Firefox profile to another.  For most of the prefs (like browser.startup.homepage) this is exactly what we want.  If we want to selectively sync certain prefs like Personas *between* desktop and mobile, then we will need to do more work.
Attachment #503299 - Flags: review?(mconnor)
Attachment #503299 - Flags: review?(mark.finkle)
Comment on attachment 503299 [details] [diff] [review]
patch

Correct from a Sync perspective, at least!
Attachment #503299 - Flags: review?(mconnor) → review+
Comment on attachment 503299 [details] [diff] [review]
patch

Seems useful, cheap and low risk
Attachment #503299 - Flags: review?(mark.finkle) → review+
Pushed patch to enable mobile<->mobile syncing of personas and other prefs: http://hg.mozilla.org/mobile-browser/rev/bf5905ec84a8

Please file a followup if we want desktop<->mobile sync of any of these prefs.  That will probably take more work, likely post-4.0.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Summary: Allow syncing of personas to fennec → Allow syncing of prefs in fennec
Will come back and verify this fix after Bug 626973 is fixed.   Also will clone and file a new bug for comment 5
Blocks: 627185
Verified fix on android and maemo.

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre Fennec/4.0b4pre	

Mozilla/5.0 (Android; Linux armv71; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre Fennec/4.0b4pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.