Closed
Bug 624928
Opened 13 years ago
Closed 13 years ago
validator should not stop validating tiers when there are just warnings
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.12.6
People
(Reporter: kumar, Assigned: basta)
Details
Attachments
(1 file)
|
363.77 KB,
application/x-xpinstall
|
Details |
STR: - upload/validate an addon that will produce warnings in the first tier (like the one attached) Expected: - the validator should keep validating other tiers Actual: - all other tiers say Not Run as if errors occurred. In the JSON output I verified that ending_tier is 1
|
Reporter | |
Comment 1•13 years ago
|
||
Note that zamboni is validating with determined=False because of bug 615426
Assignee: nobody → mbasta
|
||
Comment 2•13 years ago
|
||
Stopping on errors is fine, stopping on warnings isn't.
Target Milestone: --- → 5.12.6
|
Assignee | |
Comment 3•13 years ago
|
||
Done: https://github.com/mattbasta/amo-validator/commit/ba476c6ac77b0cc58ab383c9f543df401f5953a6
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 4•13 years ago
|
||
pushed to Zamboni in https://github.com/jbalogh/zamboni-lib/commit/4ba2c70 and verified using STR.
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•