625015 - update confusing error message "Could not compile basic X program"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[u367160]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101206 Ubuntu/10.04 (lucid) Firefox/3.6.13 GTB7.1
Build Identifier: 

when building mozilla-central on linux, if environment miss the xt-dev package configure process will give a confusing error message "Could not compile basic X program" and do not tell which library should be installed.

I update this error message to "Could not compile basic X program. xt-dev package not installed."

Reproducible: Always

Comment 1

[u367160]

Attachment: proposed patch to make error message more clear

Comment 2

[Boris Zbarsky [:bzbarsky]]

The package isn't called "xt-dev" on all Linux distributions, much less on the other operating systems where this code runs.  So I don't see how this message is much better than what we had before, unless you happen to be on Ubuntu Linux in particular.

(For example, it's called "xorg-x11-libXt-devel" on Fedora, "libxt6-devel" on Mandriva, etc.)

If the message actually said which _library_ we're missing, that would work for me (then the user can use their package manager to get the right package for that library).

Comment 3

[u367160]

is it ok if I add corresponding package name for Fedora and SuSE as well? because I saw there is a such error message just below that line:
Can't find header GL/glx.h for WebGL (install mesa-common-dev (Ubuntu), mesa-libGL-devel (Fedora), or Mesa (SuSE))

Comment 4

[u367160]

Attachment: proposed patch to make error message more clear

patch updated based on the comment, thanks

Comment 5

[Boris Zbarsky [:bzbarsky]]

I'm not a module peer for this code, so I can't review that patch.  But yes, listing the various package names would be a lot better.

That said, the Fedora package name is certainly wrong; there is no such package on Fedora.  Where did you get it?  Where did you get the SuSE package name?

Which files is this test actually checking for, by the way?  Your patch doesn't have enough context to tell....

Comment 6

[u367160]

Comment on attachment 503426 [details] [diff] [review]
proposed patch to make error message more clear

I've got package names from here:
https://developer.mozilla.org/En/Developer_Guide/Build_Instructions/Linux_Prerequisites

this test checking for files, it looks also checking some c headers as well, but I think X11 headers is more important here.
9213     AC_TRY_COMPILE([
9214         #include <stdio.h>
9215         #include <stdlib.h>
9216         #include <X11/Xlib.h>
9217         #include <X11/Intrinsic.h>
9218     ],

http://mxr.mozilla.org/mozilla-central/source/configure.in#9226

removed bzbarsky from reviewer

Comment 7

[Boris Zbarsky [:bzbarsky]]

> I've got package names from here:

The names in your patch don't match the ones on that page.  At least the Fedora one does not.

Comment 8

[u367160]

Attachment: proposed patch to make error message more clear

ooops, sorry my mistake. Thanks for pointing it out
patch updated

Comment 9

[vinaur]

Bumped into this message when compiling xulrunner 13.0

For the record, the "xt-dev" package for ubuntu (tried on 12.04) is "ibxt-dev"

Comment 10

[vinaur]

Sorry, typo. "libxt-dev"

Comment 11

[sylvestre]

Attachment: fix-bug-625015.diff

Here is the refreshed patches of Aikeremu Tiemuer.
I am taking the bug since there is no activity on it for a while

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30c5b0398c6f

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/30c5b0398c6f