625099 - Disabled files shouldn't be in _files

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Wil Clouser [:clouserw]]

If a file is unreviewed or rejected we should remove it from _files/ and put it somewhere else under NETAPP_STORAGE.

The same goes for any temporary storage of files (like when submitting an add-on but not yet completing it).

Comment 1

[Jeff Balogh (:jbalogh)]

What should we do with these files? They're supposed to be accessible from public pages while an add-on is unreviewed, and they have to be accessible by editors for review.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> What should we do with these files? They're supposed to be accessible from
> public pages while an add-on is unreviewed, and they have to be accessible by
> editors for review.

If they're accessible while unreviewed, this bug is INVALID.  I thought our new system wasn't going to allow any add-ons to be downloaded unless they had been reviewed.

Comment 3

[Justin Scott [:fligtar]]

It is true that unreviewed files can be downloaded as they will only be unreviewed for a short time.

Disabled files, however, should be quarantined.

Comment 4

[Wil Clouser [:clouserw]]

s/unreviewed/disabled/ then!  Thanks fligtrar (typo'd it, but the result sounds like a tiger so I'm rolling with it).

Comment 5

[Jeff Balogh (:jbalogh)]

oremj: it sounds like we need to have some files behind an auth wall (/_files is completely public). Do you have any suggestions on how to achieve this. This should be extremely low-traffic so it wouldn't kill us to serve the files through Python, but I'm morally opposed to that.

Comment 6

[Wil Clouser [:clouserw]]

-> .8 for decisions

Comment 7

[Jeff Balogh (:jbalogh)]

Merge: https://github.com/jbalogh/zamboni/commit/8efe4ae
Hiding files: https://github.com/jbalogh/zamboni/commit/35b885f
Serving files again: https://github.com/jbalogh/zamboni/commit/2d9d9d0

The serving part is broken until we work out bug 629770.

Comment 8

[Jeff Balogh (:jbalogh)]

Switching to X-SendFille + fallbacks in https://github.com/jbalogh/zamboni/commit/055a15b

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Is this QA testable without running SQL queries?

Comment 10

[Jeff Balogh (:jbalogh)]

1. Upload a file.
2. Download that file, observe the /_files/ URL where it resides.
3. Disable that file.
4. Ask me to run the hide-files cronjob.
5. Ensure the file is no longer in /_files/.
6. Log out, observe a 404 from the /downloads/file/ URL for that file.
7. Log in as an admin, see that /downloads/file/ returns your file from #2.
8. Log in as a non-admin owner of that file, see that /downloads/file/ returns your file from #2.
9. Ask oremj to set XSENDFILES=False on preview, repeat #7 or #8.
10. PROFIT!!!!

Comment 11

[krupa raj[:krupa]]

verified @ https://addons-cdn.allizom.org/_files/275083/addon-1.3-fx.xpi

thanks for the STR.