Make logHelper's mark_failure work a little better

RESOLVED FIXED in Thunderbird 3.3a2

Status

MailNews Core
Testing Infrastructure
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

unspecified
Thunderbird 3.3a2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 503234 [details] [diff] [review]
patch, v1

(Yes, I'm bundling several fixes in one, but this is whatever I had to fix to get error messages in bug 624108 working properly. Plus they're all kind of related, so I'm not apologizing :) )

Three fixes:
1. Make _normalize_for_json recognize HTML elements.
2. For objects that aren't recognized, return an object instead of a string. Bad things happen when strings are tested with the in operator, as happens in mark_failure.
3. Use the JSON output in mark_failure to generate text rather than the implicit call to obj.toString().
Attachment #503234 - Flags: review?(bugmail)
Attachment #503234 - Flags: review?(bugmail) → review+
(Assignee)

Comment 1

8 years ago
https://hg.mozilla.org/comm-central/rev/3ac5765940a6
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
You need to log in before you can comment on or make changes to this bug.