625144 - GECKO_PLATFORM_INI_PATH/FENNEC_APPLICATION_INI_PATH are wrong for Mac Desktop builds

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[[e-mail] (:bhearsum)]

Attachment: [checked in] fix ini paths for non-libxul SDK mac repacks

I was attempting a Fennec Desktop repack on a Mac today and found that "make ident" failed because it couldn't find platform.ini. It appears to me that the non-libxul SDK paths are wrong for these files. Rather than:
GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/../Resources/platform.ini"
FENNEC_APPLICATION_INI_PATH="$(STAGEDIST)/../Resources/application.ini"

They should be:
GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/platform.ini"
FENNEC_APPLICATION_INI_PATH="$(STAGEDIST)/application.ini"

In the most recent nightly Desktop Mac en-US build there is no "Resources" directory.

I don't know if the libxul SDK path is still correct, but I don't think it's used 

Patch is attached.

Comment 1

[Aki Sasaki (not active)]

Comment on attachment 503246 [details] [diff] [review]
[checked in] fix ini paths for non-libxul SDK mac repacks

Having it work and not go to a non-existent directory sound good to me. r=me if Ted's ok with it.

Comment 2

[(not currently active) Ted Mielczarek]

This could be fallout from bug 557027.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 503246 [details] [diff] [review]
[checked in] fix ini paths for non-libxul SDK mac repacks

But I dunno, it's in a non-LIBXUL_SDK block, so maybe it just never worked.

Comment 4

[[e-mail] (:bhearsum)]

Drivers, the patch in this bug is a fix that makes it possible for us to have Desktop Mac l10n repacks, if we want. This codepath is not part of the en-US build, nor any repacks we currently have running. I tested it by hand and found no issues.

Comment 5

[[e-mail] (:bhearsum)]

I just realized that this is not a code path used by any infrastructure (currently), so I landed it.

Removing blocking2.0? request.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 503246 [details] [diff] [review]
[checked in] fix ini paths for non-libxul SDK mac repacks

changeset:   2649:43c93d0f958d