625190 - Typo and Missing FK in Bugzilla::DB::Schema

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[David Marshall]

Attachment: patch to correct discrepancies

I'm reconciling Bugzilla::DB::Schema with our actual database and found two discrepancies.  bugs.qa_contact has a typo, REERENCES vice REFERENCES.  bug_see_also should also have a foreign key on bugs.

Comment 1

[Frédéric Buclin]

Comment on attachment 503300 [details] [diff] [review]
patch to correct discrepancies

Unrelated to this bug: I think qa_contact should have ON DELETE CASCADE.

Comment 2

[Frédéric Buclin]

(In reply to comment #1)
> Unrelated to this bug: I think qa_contact should have ON DELETE CASCADE.

Err... I obviously meant: ON DELETE SET NULL! Thanks dwm for catching that. :)

Comment 3

[Max Kanat-Alexander]

Comment on attachment 503300 [details] [diff] [review]
patch to correct discrepancies

Oh wow, yes, thank you for catching that!

It would also be nice to add some code to delete the "REERENCES" from bz_schema....

Comment 4

[Frédéric Buclin]

This typo has been introduced in Bugzilla 3.6 by bug 462067. Shouldn't we take the typo fix for this branch? The other change in the patch is an enhancement and doesn't need to land there.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/DB/Schema.pm
Committed revision 7655.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/DB/Schema.pm
Committed revision 7514.

Comment 5

[Max Kanat-Alexander]

(In reply to comment #4)
> This typo has been introduced in Bugzilla 3.6 by bug 462067. Shouldn't we take
> the typo fix for this branch? The other change in the patch is an enhancement
> and doesn't need to land there.

  Well, unfortunately fixing the typo will also cause a database change on a stable branch--a database change on the bugs table, at that (which can be very slow). Since I don't think that the FK is really all that important, I'd rather not force a DB change on people who are running 3.6.x.