625207 - Uploading screenshots can take a long time/is slow

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

On https://addons.allizom.org/z/en-US/developers/addon/a9-9331/edit and the like:

While I can't reproduce this at-will, it seems like a problem we should look into soon (if not before we ship): sometimes (often, in fact, at least on preview), screenshots will be in the Celery-processing queue (or appear to be), but a simple click on Edit or a reload of the page will make them appear.

Other times, it seems like uploading a successive image works, while the first is still processing; not sure what's going on there.

Screencast here, but it's not that helpful in debugging (neither are headers): http://screencast.com/t/DhP9d9MKI7

Comment 1

[Jeff Balogh (:jbalogh)]

It seems like this is a problem with the polling, not with celery getting the job done.

Comment 2

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/1ab930e7d370674aaa745d160cae8c5ccc918a3e

Here's hoping

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Sadly, I can't notice a difference, on preview.

Comment 4

[Jeff Balogh (:jbalogh)]

(In reply to comment #0)
> Screencast here, but it's not that helpful in debugging (neither are headers):
> http://screencast.com/t/DhP9d9MKI7

A screencast with web console network logging *would* be helpful.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

http://screencast.com/t/pWCpLvWLfq; you want the console attached, as a log, or just visible in the screencast?

Comment 6

[Andy McKay]

I think there's more than polling going on here.

You upload a screenshot, click save. Image not present, polling message appears.

After a while click edit. You should have one screenshot uploaded, but you don't. It's not present in the edit form at all. Where did that screenshot go?

Comment 7

[Gregory Koberger (:gkoberger)]

Fix for Comment #5 screencast (Where even an empty box doesn't even show up):

http://github.com/jbalogh/zamboni/commit/3fafd36

Comment 8

[Gregory Koberger (:gkoberger)]

As far as I can tell, this is number of different bugs all combined into one:

1. EMPTY BOX DOESN'T SHOW UP:
When you hit save before the image is uploaded, nothing is saved for the screenshot and you don't even get an empty box when you hit save.
Example: http://screencast.com/t/pWCpLvWLfq
Status: Fixed.

2. BOX IS BLANK UNTIL YOU HIT SAVE:
See bug 625281
Solution: Use DataURL, similar to how icons are done.

3. BOX IS BLANK AFTER YOU HIT SAVE:
We'll try to show a dataURL if we can, or we'll show a "Your Image is Processing" image if we can't.  We'll need to use andy's polling script for this, too, to update it when it is available.

Comment 9

[Wil Clouser [:clouserw]]

> 3. BOX IS BLANK AFTER YOU HIT SAVE:
> We'll try to show a dataURL if we can, or we'll show a "Your Image is
> Processing" image if we can't.  We'll need to use andy's polling script for
> this, too, to update it when it is available.
That's actually bug 624435

Comment 10

[Gregory Koberger (:gkoberger)]

Krupa, go!

http://github.com/jbalogh/zamboni/commit/dabb667

(This fixes 1 and 2 from comment 8; 3 is bug 624435)

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm happy with how it works now, for the most part -- there are and will be spinoff bugs for the remaining issues.

Verified!