cef logging not generally taking a username

RESOLVED FIXED

Status

Cloud Services
Server: Core
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: telliott, Assigned: telliott)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Assignee)

Description

7 years ago
I noticed while reviewing some other code that the usual line for cef logging doesn't take a username. Ignoring the fact that we should probably have that be a normal parameter (since 90% of the time we'll want it), there are several places in the python that probably need to add {'suser': username} to the **params
(Assignee)

Updated

7 years ago
Assignee: nobody → tarek
Let's make it a normal parameter then, defaulting to None.

Updated

7 years ago
Blocks: 608039
Created attachment 504480 [details] [diff] [review]
Added the suser value
Attachment #504480 - Flags: review?(telliott)
(Assignee)

Comment 3

7 years ago
should we put username in front of signature? I'm far more likely to put in a username than a signature.
Yeah sure. 

Also, maybe we should rename it to log_cef() now that it's used in other spots than log failures. It will be more painful to do so once we have more apps.
(Assignee)

Comment 5

7 years ago
Sure, that seems fine. We could even leave in the log_failure function as a pointer to log_cef for a bit to ensure nothing breaks.
Since nothing using server-core is in production yet, I think having a deprecation process for that name is unnecessary: we can rename it everywhere with no impact but the need to update it in all stage environment -- and gives a heads-up to JR about this.
Created attachment 505372 [details] [diff] [review]
Added the suser value and renamed the function

Revised version
Attachment #504480 - Attachment is obsolete: true
Attachment #505372 - Flags: review?(telliott)
Attachment #504480 - Flags: review?(telliott)
Created attachment 505374 [details] [diff] [review]
s/log_failure/log_cef in server-reg
Attachment #505374 - Flags: review?(telliott)
Created attachment 505379 [details] [diff] [review]
s/log_failure/log_cef in server-key-exchange
Attachment #505379 - Flags: review?(telliott)
(Assignee)

Updated

7 years ago
Attachment #505374 - Flags: review?(telliott) → review+
(Assignee)

Updated

7 years ago
Attachment #505379 - Flags: review?(telliott) → review+
Created attachment 506333 [details] [diff] [review]
Added the suser value and renamed the function
Attachment #505372 - Attachment is obsolete: true
Attachment #506333 - Flags: review?(telliott)
Attachment #505372 - Flags: review?(telliott)
(Assignee)

Comment 11

7 years ago
Comment on attachment 506333 [details] [diff] [review]
Added the suser value and renamed the function

Looks good. I'll attach the account portal changes here, too
Attachment #506333 - Flags: review?(telliott) → review+
(Assignee)

Comment 12

7 years ago
Created attachment 506485 [details] [diff] [review]
changes log_failure to log_cef
Attachment #506485 - Flags: review?(tarek)

Updated

7 years ago
Attachment #506485 - Flags: review?(tarek) → review+

Updated

7 years ago
Assignee: tarek → telliott
(Assignee)

Comment 14

7 years ago
Done on account-portal in http://hg.mozilla.org/services/account-portal/rev/1a2b8dfb04a6
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.