625242 - cef logging not generally taking a username

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Toby Elliott [:telliott]]

I noticed while reviewing some other code that the usual line for cef logging doesn't take a username. Ignoring the fact that we should probably have that be a normal parameter (since 90% of the time we'll want it), there are several places in the python that probably need to add {'suser': username} to the **params

Comment 1

[Tarek Ziadé (:tarek)]

Let's make it a normal parameter then, defaulting to None.

Comment 2

[Tarek Ziadé (:tarek)]

Attachment: Added the suser value

Comment 3

[Toby Elliott [:telliott]]

should we put username in front of signature? I'm far more likely to put in a username than a signature.

Comment 4

[Tarek Ziadé (:tarek)]

Yeah sure. 

Also, maybe we should rename it to log_cef() now that it's used in other spots than log failures. It will be more painful to do so once we have more apps.

Comment 5

[Toby Elliott [:telliott]]

Sure, that seems fine. We could even leave in the log_failure function as a pointer to log_cef for a bit to ensure nothing breaks.

Comment 6

[Tarek Ziadé (:tarek)]

Since nothing using server-core is in production yet, I think having a deprecation process for that name is unnecessary: we can rename it everywhere with no impact but the need to update it in all stage environment -- and gives a heads-up to JR about this.

Comment 7

[Tarek Ziadé (:tarek)]

Attachment: Added the suser value and renamed the function

Revised version

Comment 8

[Tarek Ziadé (:tarek)]

Attachment: s/log_failure/log_cef in server-reg

Comment 9

[Tarek Ziadé (:tarek)]

Attachment: s/log_failure/log_cef in server-key-exchange

Comment 10

[Tarek Ziadé (:tarek)]

Attachment: Added the suser value and renamed the function

Comment 11

[Toby Elliott [:telliott]]

Comment on attachment 506333 [details] [diff] [review]
Added the suser value and renamed the function

Looks good. I'll attach the account portal changes here, too

Comment 12

[Toby Elliott [:telliott]]

Attachment: changes log_failure to log_cef

Comment 13

[Tarek Ziadé (:tarek)]

Done for me in :
- http://hg.mozilla.org/services/server-core/rev/230271073c16
- http://hg.mozilla.org/services/server-reg/rev/220a94044d9f

Comment 14

[Toby Elliott [:telliott]]

Done on account-portal in http://hg.mozilla.org/services/account-portal/rev/1a2b8dfb04a6

Comment 15

[Tarek Ziadé (:tarek)]

And in: http://hg.mozilla.org/services/server-key-exchange/rev/7420be65dc70