Closed Bug 625250 Opened 11 years ago Closed 11 years ago

JS Float32Array and ArrayBuffer should use background free for finalization

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: pcwalton, Assigned: gal)

References

Details

(Keywords: perf, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 2 obsolete files)

patch
5.43 KB, patch
n.nethercote
: review+
sayrer
: approval2.0+
Details | Diff | Splinter Review 
Profiling FOTN, during the GC pauses, we spend a lot of time in finalization of Float32Array on the main thread. These should be on the background thread instead.
Assignee: general → gal
Status: NEW → ASSIGNED
Attached patch patch (obsolete) — — Splinter Review 
With this patch my GC pauses in FOTN are down to 113 ms. Still noticeable (that's a loss of about 7 frames), but that's much better than before. This should help 3D stuff quite a bit.
Attached patch patch (obsolete) — — Splinter Review
Attachment #503368 - Attachment is obsolete: true
Attachment #503378 - Flags: review?(nnethercote)
Attached patch patch — — Splinter Review
Attachment #503378 - Attachment is obsolete: true
Attachment #503380 - Flags: review?(nnethercote)
Attachment #503378 - Flags: review?(nnethercote)
Attachment #503380 - Flags: review?(nnethercote) → review+
Attachment #503380 - Flags: approval2.0?
Attachment #503380 - Flags: approval2.0? → approval2.0+
Whiteboard: fixed-in-tracemonkey
You need to log in before you can comment on or make changes to this bug.