JS Float32Array and ArrayBuffer should use background free for finalization

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: pcwalton, Assigned: gal)

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

9 years ago
Profiling FOTN, during the GC pauses, we spend a lot of time in finalization of Float32Array on the main thread. These should be on the background thread instead.
Reporter

Updated

9 years ago
Assignee: general → gal
Status: NEW → ASSIGNED
Assignee

Comment 1

9 years ago
Posted patch patch (obsolete) — Splinter Review
Reporter

Comment 2

9 years ago
With this patch my GC pauses in FOTN are down to 113 ms. Still noticeable (that's a loss of about 7 frames), but that's much better than before. This should help 3D stuff quite a bit.
Assignee

Comment 3

9 years ago
Posted patch patch (obsolete) — Splinter Review
Attachment #503368 - Attachment is obsolete: true
Attachment #503378 - Flags: review?(nnethercote)
Assignee

Comment 4

9 years ago
Posted patch patchSplinter Review
Attachment #503378 - Attachment is obsolete: true
Attachment #503380 - Flags: review?(nnethercote)
Attachment #503378 - Flags: review?(nnethercote)
Attachment #503380 - Flags: review?(nnethercote) → review+
Assignee

Updated

9 years ago
Attachment #503380 - Flags: approval2.0?

Updated

9 years ago
Attachment #503380 - Flags: approval2.0? → approval2.0+
Whiteboard: fixed-in-tracemonkey
You need to log in before you can comment on or make changes to this bug.