Closed
Bug 625250
Opened 12 years ago
Closed 12 years ago
JS Float32Array and ArrayBuffer should use background free for finalization
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: pcwalton, Assigned: gal)
References
Details
(Keywords: perf, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 2 obsolete files)
5.43 KB,
patch
|
n.nethercote
:
review+
sayrer
:
approval2.0+
|
Details | Diff | Splinter Review |
Profiling FOTN, during the GC pauses, we spend a lot of time in finalization of Float32Array on the main thread. These should be on the background thread instead.
Reporter | ||
Updated•12 years ago
|
Assignee: general → gal
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 2•12 years ago
|
||
With this patch my GC pauses in FOTN are down to 113 ms. Still noticeable (that's a loss of about 7 frames), but that's much better than before. This should help 3D stuff quite a bit.
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #503368 -
Attachment is obsolete: true
Attachment #503378 -
Flags: review?(nnethercote)
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #503378 -
Attachment is obsolete: true
Attachment #503380 -
Flags: review?(nnethercote)
Attachment #503378 -
Flags: review?(nnethercote)
![]() |
||
Updated•12 years ago
|
Attachment #503380 -
Flags: review?(nnethercote) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #503380 -
Flags: approval2.0?
Updated•12 years ago
|
Attachment #503380 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/b93dcfdb15e1
Assignee | ||
Comment 6•12 years ago
|
||
follow-up fix http://hg.mozilla.org/tracemonkey/rev/dff3fccf7407
Duplicate of this bug: 625335
Whiteboard: fixed-in-tracemonkey
Comment 8•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/dff3fccf7407 http://hg.mozilla.org/mozilla-central/rev/b93dcfdb15e1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•