625287 - Show the RSS and bookmark star icons in OS X menu

Status: RESOLVED WORKSFORME

(Firefox :: Menus, defect)

Description

[Alex Limi (:limi) — Firefox UX Team]

In bug 599735, we put the feed icon in the menus for the "Subscribe" menu entry.

However, we currently special-case OS X to not show the RSS icon. This menu is already filled with favicons, so the increased discoverability of having the RSS icon show — along with it actually explaining what "Subscribe" will do for people that use RSS — is a good reason to show it on OS X too.

Additionally, since they are in the same group, and to establish a stronger link between star = bookmark, we should include the bookmark star icon for the "Bookmark This Page" entry.

(part of a larger menu cleanup, btw — Faaborg is filing related bugs — but standalone and can be resolved without the other changes)

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

The UX team is very eager to get this bug landed over the next few days in order to make Beta 11.  If anyone can get a patch for this bug posted soon, we will push hard for reviews and approval (even though this isn't blocking).

You can view all of the related bugs to clean up the traditional menu bar here: http://areweprettyyet.com/4/traditionalMenu/

Comment 2

[Frank Yan (:fryn)]

Azat, are you working on this?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> However, we currently special-case OS X to not show the RSS icon. This menu is
> already filled with favicons, so the increased discoverability of having the
> RSS icon show — along with it actually explaining what "Subscribe" will do for
> people that use RSS — is a good reason to show it on OS X too.

AFAIK, we can't remove/dim the icon when the menu item is disabled, due to platform limitations. Do you want us to add it unconditionally? A disabled menu item with an icon might look weird...

Comment 4

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #3)
> AFAIK, we can't remove/dim the icon when the menu item is disabled, due to
> platform limitations. Do you want us to add it unconditionally? A disabled menu
> item with an icon might look weird...

I think this is fine, you don't know what shade of orange/blue would be enabled/disabled anyway, so the text and the inability to select it becomes the main indicator in any case. Dimming of icons in isolation rarely works (unless you establish grayscale = disabled or similar).

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:jaws, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[:Gijs (he/him)]

The bookmarks star is shown on the bookmarks toolbar entry, and the RSS feature is gone, so gonna mark this wfm.