625513 - Cleanup CSS problems from using physical units

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 590817 landed a patch the use physical units in CSS (mozmm) for Android. There are some things we need to cleanup when running on mdpi devices:
* urlbar endcaps have white backgrounds
* browser-controls buttons are too crowded
* dropmarker is stretched in menulist controls
* the thumbnail is slightly offset in it's frame

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Shows some issues:
http://people.mozilla.com/~mfinkle/fennec/screenshots/droidpro-controls-after.png

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Found some others:
* Firefox Spark button is misaligned
* Give Feedback and Get Help on home page are re-flowed poorly
* The "stop" button image is too big and forces the urlbar to grow vertically while loading a page

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 1

This patch fixes:
* Endcaps background
* Firefox Spark (removes the "play" button)
* Fixes the get help and give feedback flow problems
* Removes dead transparent padding in the stop button image to get to 30px

I don't think we will get smaller button images for this release, so I am asking for a review on this patch alone

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch 2

While testing this, I found another problem.  At 300dpi or higher, the urlbar and endcap backgrounds are broken.  This fixes them without changing the appearance at lower resolutions, though we need new assets to properly fix the "active" backgrounds.

The only 300dpi Android device available now is the Sharp IS03 in Japan, but you can test this change by setting the "css.layout.dpi" pref to 300.  An IS03 user mentioned problems in a Market review, which I think are solved by this patch.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/6ccebf662e6a

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Matt can close this when he lands. We can file a new bug for 2.0next cleanup

Comment 7

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/527ce2a1d1c1

Comment 8

[Aaron Train [:aaronmt]]

Verified fixed w/
Mozilla/5.0 (Android; Linux armv7l; rv:2.0b13pre) Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre