Convert setup_development.sh to a python script

VERIFIED FIXED

Status

VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Details

(Whiteboard: [mozmill-1.5.2+])

Attachments

(2 attachments, 3 obsolete attachments)

Right now this script is not executable on Windows if you aren't using a msys shell. It should really be a python script so it can be used across platforms.

Also it would be great to get those scripts for the hotfix-1.5.x branch. It would make a lot of things easier.

Comment 1

8 years ago
This is not created for anything other than **mozmill** developer use. It's not for general use, and I don't know why you'd be developing anything mozilla related without msys or cygwin shells on windows.

-->WONTFIX
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 2

8 years ago
crap.  sorry for the spam, misclicked.
Resolution: FIXED → WONTFIX
Clint, this bug has exactly been filed to allow us the QA team to easily switch between branches and update the Python packages for testing. Going forward with our test environment, which is also bundled with Mozmill Crowd, there is no msys or cygwin available. Python will always be available.

I really don't see the reason behind a wontfix. If you don't care it's fine but we as QA team need a better way to handle that. Also if you don't want to fix it then let it be fixed by one of us.

Assigning to myself.
Assignee: nobody → hskupin
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Status: REOPENED → ASSIGNED
Created attachment 506372 [details] [diff] [review]
Patch v1 (master)
Attachment #506372 - Flags: review?(jhammel)
Created attachment 506373 [details] [diff] [review]
Patch v1 (hotfix-1.5.2)
Attachment #506373 - Flags: review?(jhammel)
Ultra low risk patch for hotfix-1.5.2 which help us a lot for the setup of the diffent branches. Would be great to have it for Mozmill 1.x.
Whiteboard: [mozmill-1.5.2?]

Comment 7

8 years ago
Comment on attachment 506372 [details] [diff] [review]
Patch v1 (master)

This won't work for python 1.4 as check_call is not available.  Should be:

try:
  from subprocess import check_call as call
except ImportError:
  from subprocess import call

Also, "python" should not be used as the argument.  Please use sys.executable
Attachment #506372 - Flags: review?(jhammel) → review-

Comment 8

8 years ago
Comment on attachment 506373 [details] [diff] [review]
Patch v1 (hotfix-1.5.2)

Repeated from comment 7

This won't work for python 1.4 as check_call is not available.  Should be:

try:
  from subprocess import check_call as call
except ImportError:
  from subprocess import call

Also, "python" should not be used as the argument.  Please use sys.executable
Attachment #506373 - Flags: review?(jhammel) → review-
Created attachment 506539 [details] [diff] [review]
Patch v2 [checked-in]

Revised patch for master
Attachment #506372 - Attachment is obsolete: true
Attachment #506373 - Attachment is obsolete: true
Attachment #506539 - Flags: review?(jhammel)

Comment 10

8 years ago
Comment on attachment 506539 [details] [diff] [review]
Patch v2 [checked-in]

looks good!
Attachment #506539 - Flags: review?(jhammel) → review+
Created attachment 506542 [details] [diff] [review]
Patch v2 (1.5.2)
Attachment #506542 - Flags: review?(jhammel)

Updated

8 years ago
Attachment #506542 - Flags: review?(jhammel) → review+
Whiteboard: [mozmill-1.5.2?] → [mozmill-1.5.2+]
Created attachment 506547 [details] [diff] [review]
Patch v2.1 (1.5.2) [checked-in]

This time the real patch for 1.5.2
Attachment #506542 - Attachment is obsolete: true
Attachment #506547 - Flags: review+
Comment on attachment 506547 [details] [diff] [review]
Patch v2.1 (1.5.2) [checked-in]

https://github.com/mozautomation/mozmill/commit/9e4355746bf9d9ca1f55fe03a0257bfbd82b0444
Attachment #506547 - Attachment description: Patch v2.1 (1.5.2) → Patch v2.1 (1.5.2) [checked-in]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
The setup script on 1.5.2 haven't had this script executable. I fixed that with:
https://github.com/mozautomation/mozmill/commit/23d6dc15aa52ea28d278ba113cf2ef4ccb9b6b50
Status: RESOLVED → VERIFIED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.