Closed Bug 625610 Opened 13 years ago Closed 10 years ago

nanojit: improve LIR checking to catch incorrect purity/AccSet annotations on native functions

Categories

(Core Graveyard :: Nanojit, defect)

Product:
Core Graveyard
Component:
Nanojit
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: n.nethercote, Unassigned)

Details

Bug 625333 is a scary example of what can happen if a functions purity/AccSet annotations are wrong.  

I want to improve the LIR checker to try to catch some incorrect annotations.  For this particular example, if a function has an outparam that is allocp'd and it's marked as pure/ACCSET_NONE, that's extremely suspicious and very likely a bug.

Any other suggestions for additional checks along these lines would be welcome.  If a supposedly-pure function is passed a pointer to an int, double or boolean, that seems suspicious too.
Assignee: nnethercote → nobody
Status: ASSIGNED → NEW
Product: Core → Core Graveyard
Nanojit has been dead for several years. Its Bugzilla component has been moved to the graveyard (bug 984276).

I checked all the open bugs. They're all uninteresting, so I'm WONTFIXing them all. Apologies for the bugspam.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.