625648 - Stop unsafe composures of nsAutoTArrays

Status: NEW

(Core :: XPCOM, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

According to https://bugzilla.mozilla.org/show_bug.cgi?id=625247#c8, putting a class that has an nsAutoTArray member into an nsAutoTArray will cause bad things to happen.  We should prevent this, either statically if possible or through a runtime abort if necessary.

Comment 1

[Justin Lebar (not reading bugmail)]

Putting an nsAutoTArray into a nsTArray of any sort will cause problems.  You also can't put nsAutoTArrays in pldhashtables.

Comment 2

[Justin Lebar (not reading bugmail)]

...that is, unless we make nsAutoTArray memmoveable in bug 682735.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Right, this bug was about preventing you from doing that, either statically or through a runtime abort, so that if you did you'd see a clear error instead of random crashes.