Change nsIDiskDocument to use nsIFile

VERIFIED FIXED

Status

()

Core
Layout
P3
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Simon Fraser, Assigned: Simon Fraser)

Tracking

Trunk
All
Mac System 8.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments)

(Assignee)

Description

17 years ago
Before we switch to using nsIFilePicker in the editor shell, it would be best if 
we switch nsIDiskDocument to use nsIFile instead of nsFileSpec. This will require 
changes in a few other places in the code too.

Updated

17 years ago
Keywords: donttest
(Assignee)

Comment 1

17 years ago
Created attachment 21020 [details] [diff] [review]
Editor diffs
(Assignee)

Comment 2

17 years ago
Created attachment 21021 [details] [diff] [review]
Layout diffs
(Assignee)

Comment 3

17 years ago
Created attachment 21022 [details] [diff] [review]
Embedding diffs
(Assignee)

Comment 4

17 years ago
Created attachment 21023 [details] [diff] [review]
XPCOM diffs
(Assignee)

Comment 5

17 years ago
Created attachment 21024 [details] [diff] [review]
Mailnews diffs
(Assignee)

Comment 6

17 years ago
Created attachment 21025 [details]
nsIDiskDocument.idl
(Assignee)

Updated

17 years ago
Blocks: 47553
(Assignee)

Comment 7

17 years ago
Spam owners for the various parts.

What the diffs contain: changing nsIDiskDocument to use nsIFile, rather than 
nsFileSpec, and fan-out. The fan-out includes changing nsEditorshell to use 
nsIFilePicker rather than nsIFileWidget (subsuming patches in bug 47553),
and working around a problem with multply defined nsIFileStream stuff (bug
63357).
Status: NEW → ASSIGNED

Comment 8

17 years ago
sorry to be dense.  why are we making this change?
(Assignee)

Comment 9

17 years ago
We need this change because nsFileSpec is deprecated in preference for nsIFile, 
and, more importantly, because nsIFileWidget is deprecated in preference for 
nsIFilePicker (which uses nsIFile).

Comment 10

17 years ago
sr=buster for the layout diffs
(Assignee)

Comment 11

17 years ago
Created attachment 21610 [details] [diff] [review]
Patch for mozilla/embedding revised to the tip
R=ducarroz (for mailnews part)

Comment 13

17 years ago
r=dougt on the xpcom diff.  was hoping to have time last year for a real fix:
http://bugzilla.mozilla.org/show_bug.cgi?id=63357


Comment 14

17 years ago
Embedding stuff looks fine. r=adamlock@netscape.com
(Assignee)

Comment 15

17 years ago
Fixes checked in. Testing should cover open and save files in Composer, Save As 
etc, and ensure that the correct files are saved, and that Save As tracks the new 
file.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 16

17 years ago
Marking verified in the March 5 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.