Closed
Bug 625686
Opened 13 years ago
Closed 13 years ago
Restrict include of mce/dbus-names.h in dom/system/unix/nsHapticFeedback.cpp to maemo 5
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jbos, Assigned: jbos)
References
Details
Attachments
(2 files)
483 bytes,
patch
|
Details | Diff | Splinter Review | |
485 bytes,
patch
|
romaxa
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
when building meego (maemo 6) there is no mce/dbus-names.h, since the implementation is restricted to maemo=5 anyway, restrict also the include.
Assignee | ||
Updated•13 years ago
|
Attachment #503781 -
Flags: review?(doug.turner) → review?(romaxa)
Comment 2•13 years ago
|
||
Comment on attachment 503781 [details] [diff] [review] hapticMaemo5 only ># HG changeset patch ># Parent c1c92941acb836d4c93d31bf894fb074172cf8bb > >diff -r c1c92941acb8 dom/system/unix/nsHapticFeedback.cpp >--- a/dom/system/unix/nsHapticFeedback.cpp Fri Jan 14 04:30:11 2011 -0500 >+++ b/dom/system/unix/nsHapticFeedback.cpp Fri Jan 14 04:34:26 2011 -0500 >@@ -36,7 +36,7 @@ > * ***** END LICENSE BLOCK ***** */ > > #include "nsHapticFeedback.h" >-#ifdef MOZ_PLATFORM_MAEMO >+#if (MOZ_PLATFORM_MAEMO==5) Please fix style here ^ ^ - space
Attachment #503781 -
Flags: review?(romaxa)
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #508391 -
Flags: review?(romaxa)
Comment 4•13 years ago
|
||
Comment on attachment 508391 [details] [diff] [review] Fixed :D This is NPOTB
Attachment #508391 -
Flags: review?(romaxa) → review+
Updated•13 years ago
|
Assignee: nobody → jeremias.bosch
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Attachment #508391 -
Flags: approval2.0+
Updated•13 years ago
|
Keywords: checkin-needed
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5735139db6db
Comment 7•13 years ago
|
||
Can this be marked as verified fixed?
You need to log in
before you can comment on or make changes to this bug.
Description
•