remove obsolete/bogus ns*ID* check

RESOLVED FIXED

Status

()

Core
XPCOM
P3
minor
RESOLVED FIXED
18 years ago
10 years ago

People

(Reporter: Michael Ang, Assigned: Michael Ang)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
There currently exists code in xpidl_typelib that tries to let you declare nsID
and related types without flagging them with [nsid].  E.g. "native nsID(nsID);"
instead of "[nsid] native nsID(nsID);".  I guess this was needed at some point,
but it shouldn't be needed now.

In fact, this code is never executed for the most common case (possibly
other/all cases), since |verify_method_declaration| acts as a gate and isn't as
loose.
(Assignee)

Comment 1

18 years ago
Created attachment 20485 [details] [diff] [review]
Patch to xpidl_typelib removing dead code
(Assignee)

Comment 2

18 years ago
I rebuilt all .h/.xpt files on Linux and didn't find any places relying on the
old behaviour.

mccabe/jband - Can I pls get r/sr to check it in?
Status: NEW → ASSIGNED

Comment 3

18 years ago
sr=jband. Yes, please!

Comment 4

18 years ago
r=mccabe!
(Assignee)

Comment 5

18 years ago
Should I check this in now or should someone pool this with other xpidl
changes?  Causing a rebuild to remove a dead code path seems a bit excessive.

Comment 6

18 years ago
I wouldn't worry about it.  You might try to check in at a time when not too
many people will be waiting to see their changes clear.
(Assignee)

Comment 7

18 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: xpidl → XPCOM
QA Contact: mike+mozilla → xpcom
You need to log in before you can comment on or make changes to this bug.