62577 - Sublist content disappears when unlisting.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[kinmoz]

I'm seeing this in my Win32 12/11/00 debug trunk build.

1. Create a bullet list that looks something like this:

    o A
        o 1
    o B
        o 2
    o C

2. Now select all the text in the list. (From before A to after C)
3. Now press the bullet list button on the toolbar. You now get:

    A
    B
    C

The sublist items 1 and 2 disappear, they shouldn't.

Strange thing, is that I tried to create a test case for this bug by doing step 
#1, saving it out, but reloading that file in composer, and doing steps #2 and 
#3 yield different results.

Comment 1

[Joe Francis]

moz 0.9

Comment 2

[Joe Francis]

moving a bunch of 0.9 bugs to 0.9.1

Comment 3

[kinmoz]

I'll take a look at this one.

Comment 4

[kinmoz]

Attachment: A few list test cases.

Comment 5

[kinmoz]

Attachment: Patch that fixes unlist/outdent dataloss.

Comment 6

[kinmoz]

I just attatched a patch (r=[e-mail]) that fixes the Unlist bug 
reported here, an Outdent dataloss bug, and a bug where list conversion wasn't 
coverting all nested lists.

Simon can you review it?

Comment 7

[Joe Francis]

r=jfrancis

Comment 8

[Simon Fraser [no longer active]]

sr=sfraser

Comment 9

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 10

[kinmoz]

Fixes checked into TRUNK:

    mozilla/editor/base/nsHTMLEditRules.cpp  revision 1.180
    mozilla/editor/base/nsHTMLEditRules.h    revision 1.68

Should appear in the 06/18/01 8am builds.

Comment 11

[sujay]

okay now I get the following after selecting and clicking on bullet list:

A
1
B
2
C

marking verified. reopen if this is not the correct output.

Comment 12

[rubydoo123]

no, this is not what you should get, you should get a enlarged list -- the 
result should be:

A
B
C
D
E

Comment 13

[rubydoo123]

oops, Sujay just pointed out I was being stupid, remarking fixed/verified

Comment 14

[rubydoo123]

v