62579 - RTM Crash: opening a pdf file in yahoo mail [@ KERNEL32.DLL - NPPDF32.DLL]

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[marina]

**** observed with 2000-12-08 MTrunk build ****

after opening a pdf file in my yahoo mail account all attempts to go back to the
Inbox (or any link in yahoo mail) are failing: Nscp6 crashes
( i can open a pdf file in browser without a crash , it occurs only in yahoo mail
 here is a stack:
Stack:     (Signature = PluginViewerImpl::GetDOMDocument d72aa3c0)
     PluginViewerImpl::GetDOMDocument
[d:\builds\seamonkey\mozilla\modules\plugin\nglsrc\nsPluginViewer.cpp, line 407]
     nsDocShell::GetInterface
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line 255]
     nsWebShell::GetInterface
[d:\builds\seamonkey\mozilla\docshell\base\nsWebShell.cpp, line 347]
     nsGetInterface::operator()
[d:\builds\seamonkey\mozilla\xpcom\base\nsIInterfaceRequestor.cpp, line 39]
     nsCOMPtr_base::assign_from_helper
[d:\builds\seamonkey\mozilla\xpcom\base\nsCOMPtr.cpp, line 66]
     ValidateOrigin [d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp,
line 631]
     nsURILoader::GetTarget
[d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp, line 720]
     nsURILoader::OpenURIVia
[d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp, line 778]
     nsURILoader::OpenURI
[d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp, line 522]
     nsDocShell::DoChannelLoad
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line 3463]
     nsDocShell::DoURILoad
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line 3241]
     nsDocShell::InternalLoad
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line 3006]
     nsWebShell::HandleLinkClickEvent
[d:\builds\seamonkey\mozilla\docshell\base\nsWebShell.cpp, line 841]
     OnLinkClickEvent::HandleEvent
[d:\builds\seamonkey\mozilla\docshell\base\nsWebShell.cpp, line 695]
     PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 577]
     _md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c,
line 1055]
<../images/spacer.gif>

Comment 1

[Fabian Guisset]

*** Bug 62581 has been marked as a duplicate of this bug. ***

Comment 2

[Asa Dotzler [:asa]]

plugins maybe.  

Comment 3

[shrirang khanzode]

I could open a 93k pdf file successfully in yahoo mail and was able to work 
fine. Let me try a bigger file...

Comment 4

[shrirang khanzode]

I created a test account on yahoo for this : user  nettester2001 ; password: 
tester. 

Comment 5

[Jay Patel [:jay]]

Adding crash, topcrash and [@ KERNEL32.DLL - NPPDF32.DLL] for tracking purposes.

Comment 6

[Peter Lubczynski]

Looking at the stack trace, I think this is caused because with a full-page 
plugin, there is no DOM document and therefore we pass a null mDocument in 
PluginViewerImpl::GetDOMDocument. My patch will fix the crash, but you will 
still get the other asserts. Also, it would probably be a good idea to run a 
leak detection tool on this kind of case.

Comment 7

[Peter Lubczynski]

Attachment: simple patch to check for a null mDocument

Comment 8

[Peter Lubczynski]

Andre, can I get a review for this patch?

Comment 9

[av (gone)]

r=av

Comment 10

[buster]

sr=buster
took the libery of bumping up the priority and severity to realistic values for
a crash.

Comment 11

[Peter Lubczynski]

Patch check-ed in.

Comment 12

[Peter Lubczynski]

Marking Fixed

Comment 13

[marina]

i didn't crash displaying .pdf files though i do experience some difficulties to
display them : sometimes files come up empty.

Comment 14

[lchiang]

peter - were you ever able to reproduce the crash using PDF files in the steps
outlined in this bug report?  We need a way to test out your fix since Shrirang
was never able to reproduce the crash in the first place.  Thanks.

Comment 15

[Peter Lubczynski]

yes, simply follow the directions for the bug.

If you log into Yahoo Mail! with the username/password above you'll see a 
message that has an attached PDF. Try that.

Also, this has only been checked into the trunk. Wondering if I can check into 
the branch as it's a top crasher?

Comment 16

[Angela Butler]

Added branch accept to status whiteboard.  Peter, please check into the branch 
ASAP. Thx
.Angela...

Comment 17

[Peter Lubczynski]

Patch checked into the BRANCH.

Comment 18

[shrirang khanzode]

verified fixed on windows trunk and branch builds (0117). No crash is seen, 
attachment opens properly.Marking VERIFIED