625868 - Talos should throw an error if it is missing a sample config

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[cmtalbert]

1. Pretend you don't know what you're doing
2. Stare at the options available from the perfconfigurator
3. Try to make the perfconfigurator run and forget to include the sample config.

I finally figured out the reason things weren't happy was that my configs weren't working, and in a last ditch effort I went hunting for the perfconfigurator command used by buildbot in the build logs.  That's how I discovered that a sample config was required.

Can we just change remotePerfConfigurator and perfconfigurator to throw an error if a sampleconfig is not provided?

Comment 1

[alice nodelman [:alice] [:anode]]

Should be a very small patch.

I believe that step #1 should be assumed for all bug reports. :)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I should add a couple examples in remotePerfConfigurator of how to use it to run a successful test.  For example we use about 10 options and it is hard to remember these.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: check for sampleConfig on the cli and while opening the file (1.0)

simple patch to clean up the checking of sampleConfig while making it required.

Comment 4

[alice nodelman [:alice] [:anode]]

Comment on attachment 504595 [details] [diff] [review]
check for sampleConfig on the cli and while opening the file (1.0)

I would leave the default as 'sample.config' instead of '' - since that is the provided config filed in the checked in version of talos it seems right that that should be the default.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: check for sampleConfig on the cli and while opening the file (2.0)

updated to use remote.config as the default for remotePerfConfigurator and put back sample.config as the default for desktop.

Comment 6

[alice nodelman [:alice] [:anode]]

Comment on attachment 504858 [details] [diff] [review]
check for sampleConfig on the cli and while opening the file (2.0)

This pleases me.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/pushloghtml?changeset=c923f319b967