625870 - Add JS_NewDateObject, JS_NewDateObjectMsec, JS_ObjectIsDate to the JSAPI

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Paprocki]

Attachment: Patch to add functions to jsapi.h/jsapi.cpp

In our embedding code, we need to create JS Date objects and determine if objects are dates. We do this right now by using the underlying non-public methods. I'd like to get these added to the public API so we are not poking inside the engine for them.

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 503949 [details] [diff] [review]
Patch to add functions to jsapi.h/jsapi.cpp

Looks great to me. I think it's well worth taking, even this close to the release, because it's a community contribution and can't introduce bugs in our stuff, because we won't be calling the new functions.

Comment 2

[Brendan Eich [:brendan]]

We should take this.

/be

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 503949 [details] [diff] [review]
Patch to add functions to jsapi.h/jsapi.cpp

Agree, land away.

Comment 4

[Jason Orendorff [:jorendorff]]

Thanks, ap!

http://hg.mozilla.org/tracemonkey/rev/27bf86dbdb52

(Rats, I forgot to put the bug number in the commit message. Shouldn't be too awful for anyone, I hope.)

Comment 5

[Jason Orendorff [:jorendorff]]

Backed out due to a silly mistake (JS_NewDateObject has two parameters named m):

  https://hg.mozilla.org/tracemonkey/rev/75354982793c

I've fixed that locally and I'll re-push later today.

Comment 6

[Jason Orendorff [:jorendorff]]

Take 2: https://hg.mozilla.org/tracemonkey/rev/54a8ab97c419

Comment 7

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/54a8ab97c419

Comment 8

[Eric Shepherd [:sheppy]]

evilpie documented these; I tidied them up and added them to the list on the JSAPI Reference page.