625883 - Fix tap highlight on about:home

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch v1

Tap highlighting doesn't look right on about:home. For some reason the active style on divs with role="button" isn't applied in the addons area, but works fine in the recent tabs area. Overriding with !important fixes it, but I'm not sure who is overriding the style (i.e. we shouldn't have to do that).

The remote tabs button also has an unnecessary outline in highlighted state.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 503957 [details] [diff] [review]
Patch v1

>diff --git a/chrome/content/content.css b/chrome/content/content.css

>+div[role="button"]:active {
>+  background-color: #8db8d8 !important;
>+  outline: none !important;
>+}

Using DOMi, I found that this rule is causing the problem:
http://mxr.mozilla.org/mobile-browser/source/themes/core/aboutHome.css#159

body[dir="rtl"] #newAddons > div:not(.loading) {
  background: url("images/arrowleft-16.png") 1% center no-repeat;
}

This line causes a "background-color: transparent" to be displayed in DOMi. Deleting that property using DOMi allows the normal tap highlight rules to kick in. I assume we need the "!important" for this and other potential background issues.

Why limit the override to just div[role="button"]  ? Why not all our tap highlight rules? I don't want a "just for about:home" fix

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Hm. Didn't know you could run DOMi on Fennec, but I guess for local pages it all works. Thanks!

I'm not sure I like doing things this way. One of the things I liked about this approach was that sites COULD override it if they wanted. I guess they still can, but have to !important their own code. I don't mind us setting the example for sites either though by doing our own custom overrides for these about pages where we need to.

Also pulled in the unpushed changes from Bug 625082.

Comment 3

[Wesley Johnston (:wesj)]

Pushed:
http://hg.mozilla.org/mobile-browser/rev/14063db434f4

Comment 4

[ahoza]

Verified as fixed on: 
Mozilla /5.0 (Maemo;Linux armv7l;rv:2.0b10pre)Gecko/20110119 Firefox/4.0b10pre
Fennec /4.0b4pre and
Mozilla /5.0 (Android;Linux armv7l;rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre Fennec /4.0b4pre

Comment 5

[Wesley Johnston (:wesj)]

Attachment: followup

Crud. There was a typo in the above patch.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 505215 [details] [diff] [review]
followup

-moz-box-shadow -> box-shadow

Comment 7

[Wesley Johnston (:wesj)]

pushed follow up to remove moz-box-shadow entirely:

http://hg.mozilla.org/mobile-browser/rev/8b2710b52026

Comment 8

[Dão Gottwald [:dao]]

bugspam